Repository navigation
Document gotchas with sources generated in actions during sync_release - #1180
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
|
Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away. |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 11:27 AM UTC · Completed 11:38 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $3.61 |
|
<!-- fullsend:risk-assessment --> DetailsThis docs-only PR adds 10 lines to one file, with no protected, security-sensitive, CI or dependency paths, from an established non-bot author, and the file has had no commits in 90 days; the weighted composite is 1.47, which rounds to 1. |
ReviewFindingsMedium
Low
Labels: Docs-only change about release-sync and lookaside-cache behaviour for Fedora dist-git, matching the linked issue labels. Next steps:
|
…ncing Co-Authored-By: GPT-6.1 Sol <noreply@openai.com> Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com>
Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com> Co-Authored-By: GPT-6.1 Terra <noreply@openai.com>
57b79c1 to
23917af
Compare
commented
Oct 28, 2026
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 08s |
Summary
Document the gotcha that actions generating sources during release syncing run once per target dist-git branch: a non-reproducible generator can produce a different archive hash on each run, causing another lookaside upload per branch when that content is absent from the cache and uploads are enabled. The new note recommends making generation reproducible, which lets fedpkg/centpkg avoid uploading a file whose name and hash are already in the cache for the same package, even when Packit still runs the upload step on a branch whose
sourcesfile does not list the archive yet, and, where generation cannot be made reproducible, describes checking Fedora's lookaside cache for the archive by name and downloading it instead of generating it again.Related Issues and Pull Requests
Fixes #911
Changes
docs/configuration/examples.md: a note under "Custom archive creation for release syncing" explaining thatpost-upstream-cloneandpre-syncrun once per target branch processed by the release-sync loop, that non-reproducible generation (changing timestamps, randomness) can change the archive hash per run and trigger another lookaside upload per branch when that content is absent from the cache and uploads are enabled, that with reproducible generation fedpkg/centpkg avoid uploading a file whose name and hash are already cached for the same package (Packit itself skips the upload step only when every archive is in the cache and listed in the branch'ssourcesfile and--force-new-sourcesis not set), and, for generation that cannot be made reproducible, how to check Fedora's lookaside cache index (https://src.fedoraproject.org/repo/pkgs/<package>/, package name inPACKIT_DOWNSTREAM_PACKAGE_NAME) for the archive by name and reuse it.Testing
Docs-only change; nothing was executed locally. The Fedora lookaside index path the note names was checked live: https://src.fedoraproject.org/repo/pkgs/packit/ and each level below it down to an archive file returned HTTP 200. Fork CI green on the branch head 23917af: workflow run 40686921149 on the fork, 1 job green, provenance echo naming that SHA. Upstream CI on this PR: Test deployment green (run 40686913554), zuul
packit-service/checksuccess, pre-commit.ci pass.Footer
Generated by GLM-5.3-Flash (brief, orchestration), GPT-6.1 Sol (research, implementation, review), GPT-6 Astra (review), Claude Opus 5.5 (brief, orchestration), GPT-6.1 Terra (implementation)