Repository navigation
Document that the CLI uses top-level configuration for shared keys - #1181
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 10s |
|
Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away. |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 11:30 AM UTC · Completed 11:40 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $3.88 |
|
<!-- fullsend:risk-assessment --> DetailsDocs-only PR touching 3 Markdown files (+42 lines) from a returning contributor, no protected/security/CI/dependency paths, low churn, and a narrowly scoped linked issue; composite 0.51.13 + 0.31.43 + 0.2*2.00 = 1.39 rounds to 1. |
ReviewFindingsLow
Labels: Documentation-only PR describing how the Packit CLI uses configuration values. Next steps:
|
5250e71 to
22497c0
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 09s |
|
The |
Explain which configuration ordinary CLI workflows use when shared keys differ between package and job levels. Describe the commands that read job-level values, validation behavior, CLI option precedence, and how Packit Service applies job overrides. Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com> Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com> Co-Authored-By: GPT-6.1 Terra <noreply@openai.com>
Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com> Co-Authored-By: GPT-6.1 Terra <noreply@openai.com>
Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com> Co-Authored-By: GPT-6.1 Terra <noreply@openai.com>
22497c0 to
052834b
Compare
Summary
Documents which configuration values the ordinary Packit CLI uses for keys that exist both at top level and at job level (for example
actionsorversion_update_mask), and which CLI commands do read job-level values.Related Issues and Pull Requests
Fixes #1083
Changes
docs/configuration/jobs.md: new "CLI configuration" section after the job-level override example — job-level values of shared keys are accepted and validated and become part of the job's effective configuration (used by Packit Service), while ordinary CLI commands use the package configuration (top-level, or package-level withpackages); enumerates the exceptions (prepare-sources --job-config-index, experimentalbuild in-image-builder,propose-downstream/pull-from-upstreamreading the matching job'sdist_git_branches,build in-coprreading the qualifying job'sprojectwhen--projectis absent,validate/config validate); notes that invalid job-level values can still fail loading or validation, and that CLI options take precedence.docs/configuration/actions.md: one sentence in theactionscaution block pointing CLI readers to the new section.docs/configuration/index.md: qualifies the "Both Packit Service and Packit CLI use this configuration file" statement and links to the new section.docs/cli/index.md: cross-link from the Commands section to the same explanation.Testing
Docs-only change, checked by the site build (
make import+yarn build). Gates that ran, all green on head22497c097a5c23407d636af35b3ab836dd4178bd: workflow run 40689037979 on the fork (provenance echo names that SHA), upstream Test deployment (run 40689027872), Zuulpackit-service/check, and pre-commit.ci. The documented behavior was verified against current packit/packit source: the configuration loader merges job-level shared keys into the job's effective configuration while CLI commands receive the package configuration, with the listed commands consuming job-level values.Footer
Generated by GLM-5.3-Flash (brief), GPT-6.1 Sol (implementation), GPT-6 Astra (review), GPT-6.1 Terra (implementation), Claude Opus 5.5 (brief)