Skip to content

fix: document copr_dist_git - #1186

Merged
mfocko merged 2 commits into
packit:mainfrom
mfocko:fix/PACKIT-5590
Nov 9, 2026
Merged

mfocko merged 2 commits into
packit:mainfrom
mfocko:fix/PACKIT-5590

Conversation

@mfocko

@mfocko mfocko commented Nov 1, 2026

Copy link
Copy Markdown
Member

Fixes PACKIT-5590

Assisted-by: GPT-6-Luna medium

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:29 PM UTC · Completed 7:37 PM UTC

Commit: 352a962 · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $3.09

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Nov 1, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Docs-only change (2 Markdown files, 10 added lines) by a returning contributor with no protected, security-sensitive, CI, or dependency paths; low recent churn, no missing coupled files and no reverts yield a composite of ~1.2 (Tier 1 1.13, Tier 2 1.29, 62/38 weighting with no linked issue).

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

A 2-file, 5-line docs-only change by an established member with no protected or security-sensitive paths and quiet git history scores 1 on almost every dimension (composite 1.19, rounded to 1).

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review

Findings

Medium / Low / Info

  • [api-contract] docs/configuration/index.md:628 — The new copr_dist_git section says it selects the Copr dist-git instance and "defaults to fedora". That matches the packit config schema, but Packit Service does not use the value yet: on packit-service main, packit_service/worker/helpers/build/copr_build.py (~L682-690) calls create_from_distgit(..., distgit="rhai", ...) with a # TODO: parametrize this hardcoded value and never reads copr_dist_git. The fix (packit-service PR #3215, "fix: do not hard-code ‹copr_dist_git›") is still open. Until it ships, setting the option has no effect, and users relying on the documented fedora default will actually build against rhai. The new link in copr_build.md also presents the option as usable today. (The use_copr_dist_git_build section checks out: bool, default false, ignored by the CLI.)
    Remediation: Merge after packit-service PR #3215 is merged and deployed, or add a note that Packit Service does not honour copr_dist_git yet (dist-git builds currently use the rhai instance).
  • [provenance-warning] — Prior review context discarded: provenance validation failed (unverifiable-wrong-app). This review treats all findings as first-time assessments.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY29uZmlndXJhdGlvbi9pbmRleC5tZCIsImlkIjoiZl84ZDliMGY5YzZjNjNhMDU0IiwibGluZSI6NjIyLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiZG9jcy9jb25maWd1cmF0aW9uL2luZGV4Lm1kIiwiaWQiOiJmXzYxZGY0Y2VjMzFjNDMwNWUiLCJsaW5lIjo2MjIsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL2NvbmZpZ3VyYXRpb24vdXBzdHJlYW0vY29wcl9idWlsZC5tZCIsImlkIjoiZl85YWVmZDAxMjM0YWVjZTU5IiwibGluZSI6OTMsImFjdGlvbmFibGUiOnRydWV9XX0= -->

Review

Findings

Medium

  • [incomplete-doc] docs/configuration/index.md:622: The new copr_dist_git entry here and the new bullet at docs/configuration/upstream/copr_build.md:93 both say the option is "used with use_copr_dist_git_build". That option is not documented anywhere in these docs. Those two new lines are the only places it appears: there is no heading for it, no entry among the Copr build options, and no page that describes Copr dist-git builds. Readers cannot find out what this prerequisite does, where it goes, what its type or default is, or how to turn it on. packit's CHANGELOG also says use_copr_dist_git_build is ignored by the CLI and only works in the service. The new text does not say so, which may lead CLI users to expect copr_dist_git to work for them.
    Remediation: Document use_copr_dist_git_build: boolean, default false, service-only, ignored by the CLI. Put it next to copr_dist_git in docs/configuration/index.md or in the Copr build options in copr_build.md, and link to it from index.md:622 and copr_build.md:93. If the option is meant to stay undocumented, reword the copr_dist_git entry so it does not send readers to it, and say that it applies only to Copr builds submitted by the service.

Low

  • [api-contract] docs/configuration/index.md:622: The new docs say copr_dist_git picks the Copr dist-git instance and defaults to fedora. On packit-service's default branch, packit_service/worker/helpers/build/copr_build.py (around lines 682-691) calls create_from_distgit(..., distgit="rhai", ...) with the comment # TODO: parametrize this hardcoded value, and nothing in that code reads copr_dist_git. The open companion PR fix: do not hard-code ‹copr_dist_git› packit-service#3215 targets the same ticket (PACKIT-5590). Until it ships, the option does nothing and builds go to rhai, so this is a merge/deploy ordering risk rather than a wrong description.
    Remediation: Merge this docs change only after fix: do not hard-code ‹copr_dist_git› packit-service#3215 is merged and deployed, and link the two PRs to each other. If the docs need to go out first, add a note that the service only honors the option once that change ships.
  • [doc-style] docs/configuration/upstream/copr_build.md:93: Every other item in the "Top level keys affecting a Copr build" list (merge_pr_in_ci, update_release, release_suffix, srpm_build_deps) is a bare link to its section in docs/configuration/index.md. The new copr_dist_git item is the only one with an inline description, which breaks the list format and repeats text from index.md.
    Remediation: Drop the inline description so the item matches the others: * [**copr_dist_git**](https://packit.dev/docs/configuration#copr_dist_git).

Labels: Documentation-only change describing a Copr configuration option.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added kind/documentation Improvements to docs area/copr Related to the Copr integration area/config Related to the configuration labels Nov 1, 2026
Fixes PACKIT-5590

Assisted-by: GPT-6-Luna medium
Signed-off-by: Matej Focko <mfocko@packit.dev>
Assisted-by: GPT-6-Luna medium
Signed-off-by: Matej Focko <mfocko@packit.dev>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Review · ❌ Terminated · Started 7:57 AM UTC · Ended 8:24 AM UTC

Commit: 0223d10 · View workflow run →

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

(*bool*) Set to `true` to tell Packit Service that the repository is in dist-git format and to submit Copr builds
using Copr's dist-git build workflow. Defaults to `false`. Packit CLI ignores this option.

#### copr_dist_git

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] api-contract

The new copr_dist_git section says the option selects the Copr dist-git instance for dist-git builds and 'defaults to fedora'. That matches the packit config schema (packit/schema.py, packit/config/common_package_config.py), but Packit Service does not consume the value yet: on packit-service main, packit_service/worker/helpers/build/copr_build.py (~L682-690) calls create_from_distgit(..., distgit="rhai", ...) with a # TODO: parametrize this hardcoded value comment and never reads copr_dist_git. The fix (packit-service PR #3215, 'fix: do not hard-code ‹copr_dist_git›') is still open. Until it is merged and deployed, setting copr_dist_git has no effect, and users relying on the documented fedora default will actually build against rhai. The new link in copr_build.md also presents the option as usable today. (The use_copr_dist_git_build section checks out: bool, default false, ignored by the CLI per packit 1.17.0 changelog.)

Suggested fix: Merge this only after packit-service PR #3215 is merged and deployed, or add a note to the copr_dist_git section stating that Packit Service does not honour it yet (dist-git builds currently use the rhai instance) until that change ships.

@fullsend-ai-review

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:57 AM UTC · Completed 8:24 AM UTC

Commit: 0223d10 · View workflow run →

Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $3.60

@betulependule betulependule left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfocko
mfocko merged commit a077e0c into packit:main Nov 9, 2026
30 of 31 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in Packit pull requests Nov 9, 2026
@mfocko
mfocko deleted the fix/PACKIT-5590 branch November 9, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Related to the configuration area/copr Related to the Copr integration kind/documentation Improvements to docs risk/low PR risk: low

Projects

Development

Successfully merging this pull request may close these issues.

2 participants