Repository navigation
Conversation
`update_value` is called via `update_tag` in `update_version` and can error out during macro expansion, which happens in setting: ``` Entity.disabled = md.commented_out or not expand(md.body) ``` But the expand is actually not really needed here, actually I have no idea why it was added in 4659111 in the first place. It is probably some leftover logic to find undefined macros? The code works without the `expand()` and treats `%{nil}` values correctly
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 05s |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_valueis called viaupdate_taginupdate_versionand can error out during macro expansion, which happens in setting:But the expand is actually not really needed here, actually I have no idea why it was added in 4659111 in the first place. It is probably some leftover logic to find undefined macros?
The code works without the
expand()and treats%{nil}values correctlyTODO:
packit/packit.dev.Fixes #402