Skip to content

fix: prevent excessive scanning during JWT redaction - #450

Merged
santoshyadavdev merged 1 commit into
mainfrom
coderabbit/fix-jwt-redaction-performance/b88190fa
Nov 4, 2026
Merged

santoshyadavdev merged 1 commit into
mainfrom
coderabbit/fix-jwt-redaction-performance/b88190fa

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

What and why

Replace the JWT regex with a scanner that skips overlapping prefixes to prevent excessive processing of adversarial text. Apply it to form privacy messages, shared text redaction and Analog server logs while preserving signed and unsigned token matching.

Add regression coverage for matching compatibility, overlapping candidates and plugin text redaction before clipping.

How it was verified

Inspected the pinned diff and commit requirements. Tests and validation commands were not run.

View coding task

<!-- coderabbit-ai-generated:v1 -->
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 891a6001-dbb8-4c50-9117-85f4446cc67d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added the area: package The ng-devtools package (packages/ng-devtools) label Nov 4, 2026
@nx-cloud

nx-cloud Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit a4b38d5

Command Status Duration Result
nx affected -t test build ✅ Succeeded 44s View ↗
nx build --configuration development ✅ Succeeded 17s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-11-04 05:53:53 UTC

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
a4b38d5 2026-11-04T05:53:18.734Z View logs ↗

@santoshyadavdev
santoshyadavdev merged commit dcbd285 into main Nov 4, 2026
11 of 12 checks passed
@santoshyadavdev
santoshyadavdev deleted the coderabbit/fix-jwt-redaction-performance/b88190fa branch November 4, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: package The ng-devtools package (packages/ng-devtools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant