fix(forms): quote page-derived fixture strings - #451
Merged
santoshyadavdev merged 1 commit intoNov 4, 2026
Merged
Conversation
Encode paths and statuses as TypeScript string literals so page-reported values cannot inject fixture statements. Normalize comment metadata and reject unsupported report enums. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
area: package
|
View your CI Pipeline Execution ↗ for commit 9a0c414
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
santoshyadavdev
deleted the
santoshyadavdev-fix-reactive-fixture-injection
branch
November 4, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Reactive form fixtures included page-reported paths and statuses directly in generated TypeScript, allowing malformed values to alter executable statements. Serialize those values as TypeScript string literals, keep kind and status comment fields on one line, and reject unsupported form, field, and event enum values at report ingestion.
How it was verified
pnpm commit:check(commit messages follow the guidelines)pnpm format:checkpnpm typecheck(includes thengctemplate checks)pnpm test,pnpm test:devtoolsandpnpm test:panelpnpm skills:check(when.claude/changed)apps/docsupdated andpnpm docs:buildpasses (when behavior, options, UI labels or agent tools changed), or theno-docslabel added with the reason belowpnpm extension:buildandextension/uicommitted (whenapp/changed)pnpm test:axewas attempted but could not run because Playwright Chromium was unavailable; the browser download timed out. This is a package-side security fix and does not change docs-facing behavior, so docs were not changed.Screenshots
N/A; no UI changes.
Notes for reviewers
The regression tests cover both generated-source escaping and single-line comment normalization, as well as rejection of unsupported report enum values.