Repository navigation
feat!: remove the release config check - #44
Merged
Merged
Conversation
The owner decided to delete the check. It was the only user of the deploy-actions resolver's every-service mode and its candidates output, which are being removed. Callers must stop calling reusable--test-terragrunt-release.yaml before moving to this version. A missing release-please config now shows up as a release PR that never opens. The resolver in the release build now receives exactly one service, so the service filter on its targets is dropped. Claude-Session: https://claude.ai/code/session_01N1XYRqYewzhQfyJcM9zFjG Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
release-please の設定を確かめる
reusable--test-terragrunt-release.yamlとcheck-release-configs.shを消します。What Needs to Change
candidatesの出力を必要としている。allを消して service 名の規則を 1 つにするうえで、残っている唯一の利用者だった。What Changes for Users
reusable--test-terragrunt-release.yamlを呼び出せる。What to Review Closely
なし
What Was Decided
select(.service == $service)も消す。allのときに全 target が返るのを防ぐためのもので、service を 1 つ渡す今は不要なため。What Else Is Affected
Documents
Systems & Operations
How It Was Verified
for f in scripts/*/test.sh scripts/*/*.test.sh scripts/kubernetes-hydrate/tests/*.test.sh; do bash "$f"; done→ すべて PASSgit grep -nE "check-release-configs|test-terragrunt-release|candidates"が、docs/superpowersの外で 0 件であることを確かめました。Related Issues and PRs
🤖 Generated with Claude Code
https://claude.ai/code/session_01N1XYRqYewzhQfyJcM9zFjG