Skip to content

fix: keep production dependency updates out of automerge #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panicboat merged 1 commit into from
Oct 31, 2026
Merged

fix: keep production dependency updates out of automerge #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,6 @@
"*"
]
},
{
"description": "🚫 Production environments - disable automerge",
"matchFileNames": [
"**/production/**"
],
"automerge": false,
"prPriority": -1,
"addLabels": [
"⚠️ production"
]
},
{
"description": "🚫 Major updates - disable automerge",
"matchUpdateTypes": [
Expand All @@ -72,6 +61,17 @@
"panicboat/.github"
],
"minimumReleaseAge": null
},
{
"description": "🚫 Production environments - disable automerge",
"matchFileNames": [
"**/production/**"
],
"automerge": false,
"prPriority": -1,
"addLabels": [
"⚠️ production"
]
}
]
}
6 changes: 6 additions & 0 deletions scripts/workflows/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ test_resolver_skips_label_resolver_without_a_pull_request() {
assert_eq "needs.resolve.outputs.has-targets == 'true' &&" "$(yq '.jobs["deploy-terragrunt"].if' "${workflow}" | head -n 1)"
}

test_renovate_keeps_production_out_of_automerge() {
# Renovate applies matching packageRules in order, so a later rule overrides the production rule.
assert_eq "false" "$(jq -r '[.packageRules[] | select(.automerge != null) | select(.matchFileNames // [] | index("**/production/**"))][0].automerge' "${repo_root}/default.json")"
assert_eq "production" "$(jq -r '[.packageRules[] | select(.automerge != null)] | last | if (.matchFileNames // [] | index("**/production/**")) != null then "production" else "other" end' "${repo_root}/default.json")"
}

test_workflows_do_not_read_apply_trigger() {
assert_eq "" "$(grep -rl --exclude='*test.sh' 'apply_trigger\|validate-apply-trigger' "${workflows_dir}" "${repo_root}/scripts" || true)"
}
Expand Down
Loading