Repository navigation
feat!: drop the config-path input and fail on pull request lookup errors - #49
Merged
Merged
Conversation
No caller passes config-path, and the release workflows always read the default path, so setting it would split the flows onto different files. Ignoring lookup errors made a GitHub API failure skip the label resolver and report success with no apply on main. The backend output has no reader. Claude-Session: https://claude.ai/code/session_01N1XYRqYewzhQfyJcM9zFjG Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
使われていない
config-pathの入力とbackendの出力を消し、PR 情報の取得エラーを無視しないようにします。What Needs to Change
continue-on-errorによって PR がないときと同じ扱いになり、label-resolver の step がスキップされる。config-pathの入力を、どの呼び出し側も渡していない。backendの出力を、誰も読んでいない。What Changes for Users
config-pathを受け付けません。config-pathを渡せる。workflow-config.yamlだけを読む。What to Review Closely
なし
What Was Decided
config-pathの入力は残す。What Else Is Affected
Documents
Systems & Operations
なし
How It Was Verified
for f in scripts/*/test.sh scripts/*/*.test.sh scripts/kubernetes-hydrate/tests/*.test.sh; do bash "$f"; done→ すべて PASSgh-find-current-prのソースを読み、PR がないときは成功し、API エラーのときだけ失敗することを確かめました。🤖 Generated with Claude Code
https://claude.ai/code/session_01N1XYRqYewzhQfyJcM9zFjG