Repository navigation
refactor: mark the workflows triggered by this repository's own events as self - #9
Merged
Merged
Conversation
…s as self Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
このリポジトリ自身のイベントで動く workflow を、接頭辞
self--で区別します。あわせて、拡張子を
.yamlに、name:を'Self - ...'に揃えます。Why
reusable--・internal--は呼び出し元で区別していますが、このリポジトリ自身の workflow には接頭辞がなく、release--pleaseだけが用途名の接頭辞を持っていました。同じ「誰が呼ぶか」の軸で揃えると、ファイル名と Actions の画面の両方で 3 種類を見分けられます。
Before / After
ci-gatekeeper.yaml・lint-actions.yml・semantic-pull-request.yml・test-scripts.yaml・release--please.yaml・test-shared-workflows{,--nested,--checkout}.yamlself--を付け、拡張子を.yamlに揃えます。CI Gatekeeper・Lint GitHub Actionsなど接頭辞なしSelf - CI Gatekeeper・Self - Lint GitHub Actionsなどreusable--*とinternal--*は変わりません。Decisions
ci--・release--)ではなく呼び出し元の軸でself--にしました。reusable--・internal--と基準が混ざり、reusable--release--pleaseと並んだときにどちらが自分用か分かりません。--nested・--checkout)は workflow_call ですが、internal--ではなくself--にしました。name:の接頭辞が対応していることを確かめるテストを足しました。refactorなので release は出ません。Impact
self--*の説明を足しました。Verification
bash scripts/workflows/test.shで 7 件すべて PASS しました。foo.ymlを置くとunknown prefix: foo.ymlで、name:を接頭辞なしにするとname mismatch: self--test-scripts.yamlで FAIL することを確かめました。scripts/*/test.sh・scripts/*/*.test.sh・scripts/kubernetes-hydrate/tests/*.test.shがすべて通りました。dot-github-mainの必須チェックはgatekeeper / CI Gatekeeperなどの job の名前で指定されていて、ファイル名と workflow 名は使わないので、変わりません。semantic-pull-requestはpull_request_targetなので、この PR では main にある旧ファイルが動き、merge 後から新しいファイルが動きます。Relations
internal--の接頭辞🤖 Generated with Claude Code
https://claude.ai/code/session_01AeZS4Kg4R7fZfSSUmmBYXr