Repository navigation
chore(github/repository): stop managing allow_forking - #1099
Merged
Merged
Conversation
Claude-Session: https://claude.ai/code/session_01ExEZK1E7L1oW9CCyLm5fqD Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
panicboat-github-workflow-bot
Bot
added
the
deploy:repository
Contributor
Plan Result (repository/master)
|
Contributor
✅ Apply Succeeded (repository/master)Details (Click me)Oct 23 13:45:03.584 INF download and unarchive the package program=aqua version=2.64.0 env=linux/amd64 exe_name=terragrunt package_name=gruntwork-io/terragrunt package_version=v1.0.2 registry=standard
Initializing the backend...
Successfully configured the backend "s3"! OpenTofu will automatically
use this backend unless the backend configuration changes.
Initializing provider plugins...
- Finding hashicorp/aws versions matching "~> 6.68"...
- Finding integrations/github versions matching "~> 6.13"...
- Installing integrations/github v6.13.0 to the shared cache directory...
- Installing hashicorp/aws v6.70.0 to the shared cache directory...
- Installed integrations/github v6.13.0 (signed, key ID 38027F80D7FD5FB2)
- Using integrations/github v6.13.0 from the shared cache directory
- Installed hashicorp/aws v6.70.0 (signed, key ID 0C0AF313E5FD9F80)
- Using hashicorp/aws v6.70.0 from the shared cache directory
Providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://opentofu.org/docs/cli/plugins/signing/
OpenTofu has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that OpenTofu can guarantee to make the same selections by default when
you run "tofu init" in the future.
OpenTofu has been successfully initialized!
You may now begin working with OpenTofu. Try running "tofu plan" to see
any changes that are required for your infrastructure. All OpenTofu commands
should now work.
If you ever set or change modules or backend configuration for OpenTofu,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Acquiring state lock. This may take a few moments...
github_repository.repository["platform"]: Refreshing state... [id=platform]
github_repository.repository["deploy-actions"]: Refreshing state... [id=deploy-actions]
github_repository.repository["monorepo"]: Refreshing state... [id=monorepo]
github_repository.repository["dotfiles"]: Refreshing state... [id=dotfiles]
github_repository.repository["ansible"]: Refreshing state... [id=ansible]
github_repository.repository["panicboat-actions"]: Refreshing state... [id=panicboat-actions]
github_workflow_repository_permissions.repository["monorepo"]: Refreshing state... [id=monorepo]
github_workflow_repository_permissions.repository["platform"]: Refreshing state... [id=platform]
No changes. Your infrastructure matches the configuration.
OpenTofu has compared your real infrastructure against your configuration and
found no differences, so no changes are needed.
Warning: Argument is deprecated
with github_repository.repository,
on main.tf line 12, in resource "github_repository" "repository":
12: vulnerability_alerts = true
Use the github_repository_vulnerability_alerts resource instead. This field
will be removed in a future version.
(and 6 more similar warnings elsewhere)
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.
Outputs:
repository_full_names = {
"ansible" = "panicboat/ansible"
"deploy-actions" = "panicboat/deploy-actions"
"dotfiles" = "panicboat/dotfiles"
"monorepo" = "panicboat/monorepo"
"panicboat-actions" = "panicboat/panicboat-actions"
"platform" = "panicboat/platform"
}
repository_html_urls = {
"ansible" = "https://github.com/panicboat/ansible"
"deploy-actions" = "https://github.com/panicboat/deploy-actions"
"dotfiles" = "https://github.com/panicboat/dotfiles"
"monorepo" = "https://github.com/panicboat/monorepo"
"panicboat-actions" = "https://github.com/panicboat/panicboat-actions"
"platform" = "https://github.com/panicboat/platform"
}
repository_http_clone_urls = {
"ansible" = "https://github.com/panicboat/ansible.git"
"deploy-actions" = "https://github.com/panicboat/deploy-actions.git"
"dotfiles" = "https://github.com/panicboat/dotfiles.git"
"monorepo" = "https://github.com/panicboat/monorepo.git"
"panicboat-actions" = "https://github.com/panicboat/panicboat-actions.git"
"platform" = "https://github.com/panicboat/platform.git"
}
repository_ids = {
"ansible" = 880089351
"deploy-actions" = 1014666976
"dotfiles" = 880093624
"monorepo" = 807388271
"panicboat-actions" = 1221231096
"platform" = 994278495
}
repository_node_ids = {
"ansible" = "R_kgDONHUZBw"
"deploy-actions" = "R_kgDOPHqW4A"
"dotfiles" = "R_kgDONHUpuA"
"monorepo" = "R_kgDOMB_Ebw"
"panicboat-actions" = "R_kgDOSMqB-A"
"platform" = "R_kgDOO0N8Xw"
}
repository_ssh_clone_urls = {
"ansible" = "git@github.com:panicboat/ansible.git"
"deploy-actions" = "git@github.com:panicboat/deploy-actions.git"
"dotfiles" = "git@github.com:panicboat/dotfiles.git"
"monorepo" = "git@github.com:panicboat/monorepo.git"
"panicboat-actions" = "git@github.com:panicboat/panicboat-actions.git"
"platform" = "git@github.com:panicboat/platform.git"
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
monorepo と platform は
allow_forking = false（#224）なのに、実際の設定はtrueのままで、github/repositoryの plan のたびにallow_forking = true -> falseが出続けていた（#1098 の plan で発覚）。provider の
allow_forkingは "Configure private forking for organization owned private and internal repositories"（integrations/terraform-provider-githubのresource_github_repository.go）で、個人アカウントが所有する public リポジトリには効かない。public リポジトリは誰でも fork できる。管理している 5 つのリポジトリはすべて個人所有の public なので、この設定はどれにも効かない。What
allow_forkingを module の入力とgithub_repositoryから外し、monorepo / platform のfalseを削除したallow_forkingはOptional+Computedなので、外しても差分は出ないVerification
tofu fmt -check github/repository/modules→ exit 0、git grep allow_forking -- github→ 0 件github_repositoryに差分が出ないこと（No changes）を確かめる🤖 Generated with Claude Code
https://claude.ai/code/session_01ExEZK1E7L1oW9CCyLm5fqD