Repository navigation
refactor: move workflow scripts under .github/scripts and link README paths - #1112
Merged
Merged
Conversation
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Signed-off-by: panicboat <panicboat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub Actions から実行するスクリプトが、手作業用の
scripts/eks-lifecycle/と同じscripts/に混ざっていた。workflow 用のスクリプトを
.github/scripts/にまとめ、workflow と一緒に置く。README はパスがコード表記のままで辿りにくく、もう存在しない仕組みを説明する節も残っていた。
What
scripts/terragrunt-release/とscripts/kubernetes-hydrate/を.github/scripts/に移す。render-diff.shのscript_dirと、そのテストの fixture も新しいパスに合わせる。scripts/eks-lifecycle/はscripts/に残す。docs/superpowers/の spec / plan は作業当時の記録なので、旧パスのまま残す。EKS LifecycleとClaude Code Integrationの節を削除する。claude-code-action.yamlとaws/ai-assistant/は、もう存在しない。{service}を含むテンプレートのパス、root.hclのように複数あるファイル名、run 名や job 名は、リンク先が 1 つに決まらないのでコード表記のまま残す。Deployment>Triggerを組み直す。Targets(ラベルと target の展開・exclude)とReleases(release-please・再実行)に分ける。exclude-pathsとworkflow-config.yamlの照合や、exclude の rule の一致条件は、スクリプトとテストに任せて README から外す。Merge 後の注意
kubernetes/components/を変更すると、hydrate が新しいパスのスクリプトを見つけられずに失敗する。gh pr update-branchで base を更新する。Test plan
scripts/terragrunt-release/scripts/kubernetes-hydrateへの参照がdocs/superpowers/以外に残っていない.github/scripts/kubernetes-hydrate/tests/の 2 本が通る(13/13・4/4).github/scripts/terragrunt-release/test.shが 33 件すべて PASS、validate-apply-trigger.shとcheck-release-configs.shが exit 0actionlintは既存のtarget-environmentエラー 1 件のみ🤖 Generated with Claude Code
https://claude.ai/code/session_01BZfNTtmPjmrDmh1MAMtiFS