Repository navigation
ci: name deploy and release workflows by trigger and role - #1113
Merged
Merged
Conversation
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Signed-off-by: panicboat <panicboat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
deploy と release の workflow の名前が、何で起動して何をするかと合っていなかった。
auto-label--deploy-trigger.yamlのnameはAuto Label - Label Resolverで、ファイル名とnameも食い違っていた。release-please を動かす
release.ymlだけが、命名規則から外れていた。起動のしかた(ラベル / release)と役割で名前を揃える。
What
nameを次のように変える。auto-label--label-dispatcher.yaml→label-base-deploy--dispatcher.yaml(Label Base Deploy - Dispatcher)auto-label--deploy-trigger.yaml→label-base-deploy--resolver.yaml(Label Base Deploy - Resolver)release.yml→release--please.yaml(Release - Please)auto-release--plan.yaml→release--plan.yaml(Release - Plan)auto-release--trigger.yaml→release--deploy.yaml(Release - Deploy)release-plan-…・release-deploy-…・label-base-deploy-resolver-…deploy-trigger(Deployment Trigger)からresolve(Resolve Targets)にする。descriptionキーがない(actionlint がunexpected key "description"を出す)ので、コメントで持つ。test.shが読む workflow のパスと、README / README-ja のリンク・run 名・再実行コマンド・Pipeline Flow を新しい名前に直す。docs/superpowers/の spec / plan は作業当時の記録なので、旧名のまま残す。影響
CI Gatekeeperなど)なので影響しない。<service>-vX.Y.Zの release tag はまだないので、旧名の workflow を tag の ref で再実行する場面はない。Test plan
.github/scripts/terragrunt-release/test.shが 33 件すべて PASS、validate-apply-trigger.shとcheck-release-configs.shが exit 0actionlintは既存のtarget-environmentエラー 1 件のみdocs/superpowers/以外に残っていないLabel Base Deploy - DispatcherとLabel Base Deploy - Resolverが動くRelease - Pleaseが動く🤖 Generated with Claude Code
https://claude.ai/code/session_01BZfNTtmPjmrDmh1MAMtiFS