Skip to content

chore(github/branch): stop requiring the checks that the shared workflows rename - #1119

Merged
panicboat merged 1 commit into
mainfrom
chore/relax-required-checks
Oct 24, 2026
Merged

panicboat merged 1 commit into
mainfrom
chore/relax-required-checks

Conversation

@panicboat

Copy link
Copy Markdown
Owner

Summary

monorepo・platform・deploy-actions の ruleset から、共通の workflow への切り替えで名前が変わる必須チェックを一時的に外します。

Why

各リポジトリの workflow を panicboat/.github の共通の workflow を呼ぶ形に切り替えると、check の名前が <呼び出し側の job> / <呼ばれた側の job> に変わります。
ruleset は merge 後の apply でしか変わらず、admin_bypass も false なので、切り替えの PR は古い名前を待ったまま merge できなくなります。
そのため切り替えの間だけ必須チェックを外し、切り替えがすべて終わったら新しい名前で戻します(設計書 panicboat/.github:docs/superpowers/specs/2026-10-25-shared-workflows-design.md の Required Status Checks、ユーザー決定)。

Before / After

  • monorepo の必須チェック
    • Before: CI Gatekeeper・Validate PR title・Ensure actions are pinned to SHAs・Docs Sync Check
    • After: Docs Sync Check のみ
      • Docs Sync Check は workflow が書く commit status なので、名前が変わりません。
  • platform と deploy-actions の必須チェック
    • Before: CI Gatekeeper(platform のみ)・Validate PR title・Ensure actions are pinned to SHAs
    • After: なし

Decisions

  • 外している間は CI が落ちていても merge できます。
    • 切り替えの PR は、check が緑になったことを確かめてから merge します。

Impact

  • 利用規約
  • プライバシーポリシー
  • ドキュメント

Verification

  • VERIFIED: terragrunt render --format json で、required_status_checks が monorepo は ["Docs Sync Check"]、platform と deploy-actions は [] になることを確認しました。
  • terragrunt hcl fmt --check は 3 ファイルとも name の行の揃え方で失敗しますが、main のファイルでも同じなので、この PR では触っていません。
  • plan は deploy ラベルで走ります。
    • 期待する plan は、3 つの ruleset の required_status_checks の変更だけです。

Relations

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7jQZQj1VyeBbYR7P1ssV7

…lows rename

Calling the shared workflows in panicboat/.github renames the checks to <caller job> / <callee job>.
The rulesets only change on apply after merge and admin bypass is off, so a switch PR could never satisfy the old names.

Claude-Session: https://claude.ai/code/session_01R7jQZQj1VyeBbYR7P1ssV7
Signed-off-by: panicboat <panicboat@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1cbd7f45-90c2-4465-869c-a4039ed20793
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@panicboat-github-workflow-bot panicboat-github-workflow-bot Bot added the deploy:branch Auto-generated deployment label label Oct 24, 2026
@panicboat-github-workflow-bot

Copy link
Copy Markdown
Contributor

Plan Result (branch/master)

CI link

Plan: 0 to add, 3 to change, 0 to destroy.
  • Update
    • github_repository_ruleset.branches["deploy-actions-main"]
    • github_repository_ruleset.branches["monorepo-main"]
    • github_repository_ruleset.branches["platform-main"]
Change Result (Click me)
  # github_repository_ruleset.branches["deploy-actions-main"] will be updated in-place
  ~ resource "github_repository_ruleset" "branches" {
        id          = "15519988"
        name        = "deploy-actions-main"
        # (6 unchanged attributes hidden)

      ~ rules {
            # (7 unchanged attributes hidden)

          - required_status_checks {
              - do_not_enforce_on_create             = false -> null
              - strict_required_status_checks_policy = false -> null

              - required_check {
                  - context        = "Ensure actions are pinned to SHAs" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Validate PR title" -> null
                  - integration_id = 0 -> null
                }
            }

            # (1 unchanged block hidden)
        }

        # (1 unchanged block hidden)
    }

  # github_repository_ruleset.branches["monorepo-main"] will be updated in-place
  ~ resource "github_repository_ruleset" "branches" {
        id          = "15519991"
        name        = "monorepo-main"
        # (6 unchanged attributes hidden)

      ~ rules {
            # (7 unchanged attributes hidden)

          ~ required_status_checks {
                # (2 unchanged attributes hidden)

              - required_check {
                  - context        = "CI Gatekeeper" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Ensure actions are pinned to SHAs" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Validate PR title" -> null
                  - integration_id = 0 -> null
                }

                # (1 unchanged block hidden)
            }

            # (1 unchanged block hidden)
        }

        # (3 unchanged blocks hidden)
    }

  # github_repository_ruleset.branches["platform-main"] will be updated in-place
  ~ resource "github_repository_ruleset" "branches" {
        id          = "15519990"
        name        = "platform-main"
        # (6 unchanged attributes hidden)

      ~ rules {
            # (7 unchanged attributes hidden)

          - required_status_checks {
              - do_not_enforce_on_create             = false -> null
              - strict_required_status_checks_policy = false -> null

              - required_check {
                  - context        = "CI Gatekeeper" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Ensure actions are pinned to SHAs" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Validate PR title" -> null
                  - integration_id = 0 -> null
                }
            }

            # (1 unchanged block hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

@panicboat
panicboat marked this pull request as ready for review October 24, 2026 23:58
@panicboat
panicboat merged commit 480daeb into main Oct 24, 2026
18 checks passed
@panicboat
panicboat deleted the chore/relax-required-checks branch October 24, 2026 23:58
@panicboat-github-workflow-bot

Copy link
Copy Markdown
Contributor

✅ Apply Succeeded (branch/master)

CI link

Apply complete! Resources: 0 added, 3 changed, 0 destroyed.
Details (Click me)
Oct 24 23:59:36.993 INF download and unarchive the package program=aqua version=2.64.0 env=linux/amd64 exe_name=terragrunt package_name=gruntwork-io/terragrunt package_version=v1.0.2 registry=standard

Initializing the backend...

Successfully configured the backend "s3"! OpenTofu will automatically
use this backend unless the backend configuration changes.

Initializing provider plugins...
- Finding integrations/github versions matching "~> 6.13"...
- Installing integrations/github v6.13.0 to the shared cache directory...
- Installed integrations/github v6.13.0 (signed, key ID 38027F80D7FD5FB2)
- Using integrations/github v6.13.0 from the shared cache directory

Providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://opentofu.org/docs/cli/plugins/signing/

OpenTofu has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that OpenTofu can guarantee to make the same selections by default when
you run "tofu init" in the future.

OpenTofu has been successfully initialized!

You may now begin working with OpenTofu. Try running "tofu plan" to see
any changes that are required for your infrastructure. All OpenTofu commands
should now work.

If you ever set or change modules or backend configuration for OpenTofu,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
data.github_repository.repo["monorepo"]: Reading...
data.github_repository.repo["platform"]: Reading...
data.github_repository.repo["deploy-actions"]: Reading...
data.github_repository.repo["platform"]: Read complete after 1s [id=platform]
data.github_repository.repo["monorepo"]: Read complete after 1s [id=monorepo]
data.github_repository.repo["deploy-actions"]: Read complete after 1s [id=deploy-actions]
github_repository_ruleset.branches["deploy-actions-main"]: Refreshing state... [id=15519988]
github_repository_ruleset.branches["platform-main"]: Refreshing state... [id=15519990]
github_repository_ruleset.branches["monorepo-main"]: Refreshing state... [id=15519991]

OpenTofu used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place (current -> planned)

OpenTofu will perform the following actions:

  # github_repository_ruleset.branches["deploy-actions-main"] will be updated in-place
  ~ resource "github_repository_ruleset" "branches" {
        id          = "15519988"
        name        = "deploy-actions-main"
        # (6 unchanged attributes hidden)

      ~ rules {
            # (7 unchanged attributes hidden)

          - required_status_checks {
              - do_not_enforce_on_create             = false -> null
              - strict_required_status_checks_policy = false -> null

              - required_check {
                  - context        = "Ensure actions are pinned to SHAs" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Validate PR title" -> null
                  - integration_id = 0 -> null
                }
            }

            # (1 unchanged block hidden)
        }

        # (1 unchanged block hidden)
    }

  # github_repository_ruleset.branches["monorepo-main"] will be updated in-place
  ~ resource "github_repository_ruleset" "branches" {
        id          = "15519991"
        name        = "monorepo-main"
        # (6 unchanged attributes hidden)

      ~ rules {
            # (7 unchanged attributes hidden)

          ~ required_status_checks {
                # (2 unchanged attributes hidden)

              - required_check {
                  - context        = "CI Gatekeeper" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Ensure actions are pinned to SHAs" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Validate PR title" -> null
                  - integration_id = 0 -> null
                }

                # (1 unchanged block hidden)
            }

            # (1 unchanged block hidden)
        }

        # (3 unchanged blocks hidden)
    }

  # github_repository_ruleset.branches["platform-main"] will be updated in-place
  ~ resource "github_repository_ruleset" "branches" {
        id          = "15519990"
        name        = "platform-main"
        # (6 unchanged attributes hidden)

      ~ rules {
            # (7 unchanged attributes hidden)

          - required_status_checks {
              - do_not_enforce_on_create             = false -> null
              - strict_required_status_checks_policy = false -> null

              - required_check {
                  - context        = "CI Gatekeeper" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Ensure actions are pinned to SHAs" -> null
                  - integration_id = 0 -> null
                }
              - required_check {
                  - context        = "Validate PR title" -> null
                  - integration_id = 0 -> null
                }
            }

            # (1 unchanged block hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.
github_repository_ruleset.branches["deploy-actions-main"]: Modifying... [id=15519988]
github_repository_ruleset.branches["platform-main"]: Modifying... [id=15519990]
github_repository_ruleset.branches["monorepo-main"]: Modifying... [id=15519991]
github_repository_ruleset.branches["deploy-actions-main"]: Modifications complete after 2s [id=15519988]
github_repository_ruleset.branches["platform-main"]: Modifications complete after 4s [id=15519990]
github_repository_ruleset.branches["monorepo-main"]: Modifications complete after 5s [id=15519991]

Apply complete! Resources: 0 added, 3 changed, 0 destroyed.

Outputs:

branch_protection_rulesets = {
  "deploy-actions-main" = {
    "id" = "15519988"
    "name" = "deploy-actions-main"
    "repository" = "deploy-actions"
  }
  "monorepo-main" = {
    "id" = "15519991"
    "name" = "monorepo-main"
    "repository" = "monorepo"
  }
  "platform-main" = {
    "id" = "15519990"
    "name" = "platform-main"
    "repository" = "platform"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy:branch Auto-generated deployment label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant