Skip to content

chore: replace the deprecated EFCore.BulkExtensions.Dotnet10 packages with the official ones - #78

Merged
davidnmbond merged 1 commit into
mainfrom
chore/official-bulkextensions
Oct 19, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
chore/official-bulkextensions

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

Change

Replaces the deprecated EFCore.BulkExtensions.Dotnet10.PostgreSql and EFCore.BulkExtensions.Dotnet10.SqlServer packages with the official EFCore.BulkExtensions.PostgreSql and EFCore.BulkExtensions.SqlServer, at 10.0.1.

nuget.org marks the Dotnet10 packages deprecated (Legacy): "The Dotnet10 fork was a stopgap and is no longer supported. Use the official package instead." The only code that uses the library is Context.cs (using EFCore.BulkExtensions;), and the namespace is unchanged.

Verified

  • Build succeeds with warnings as errors on.
  • dotnet test --filter "Category!=Integration", with credential-looking environment variables removed: 103 passed, 0 failed.

Not verified

The bulk-insert paths run against a real PostgreSQL or SQL Server database, and those tests are integration tests that CI and I cannot run. 10.0.0 to 10.0.1 of the official package is a patch release, but the first real run of an aggregation against a database is the check that matters, so this is worth a run on a non-production database before releasing.

Not included, left for the maintainers

These came from an automated clean-up attempt that I reviewed and did not take:

  • Serilog.Sinks.ElasticSearch (also deprecated) is referenced in the CLI project and the package pins but used nowhere in the source or the checked-in configuration. The attempt swapped it for Elastic.Serilog.Sinks, a different library with a different API. Whether to remove the reference or replace it depends on deployment configuration I cannot see.
  • A non-root user in LogicMonitor.Datamart.Cli/Dockerfile (useradd appuser, chown /app, USER appuser). Reasonable hardening, but it changes how the image runs, and the file still uses the aspnet:8.0 and sdk:8.0 bases while the project targets net10.
  • Duplication clean-ups in AggregationWriter and six mapping profiles, and cosmetic edits to two applied EF migrations. Not worth the risk to code the tests do not exercise against a database.

@codacy-production

codacy-production Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (29cc75a) 183093 3169 1.73%
Head commit (d35d359) 183093 (+0) 3169 (+0) 1.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#78) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit 98f6ddd into main Oct 19, 2026
8 checks passed
@davidnmbond
davidnmbond deleted the chore/official-bulkextensions branch October 19, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant