Repository navigation
chore: replace the deprecated EFCore.BulkExtensions.Dotnet10 packages with the official ones - #78
Merged
Merged
Conversation
… with the official ones
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (29cc75a) 183093 3169 1.73% Head commit (d35d359) 183093 (+0) 3169 (+0) 1.73% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#78) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Replaces the deprecated
EFCore.BulkExtensions.Dotnet10.PostgreSqlandEFCore.BulkExtensions.Dotnet10.SqlServerpackages with the officialEFCore.BulkExtensions.PostgreSqlandEFCore.BulkExtensions.SqlServer, at 10.0.1.nuget.org marks the Dotnet10 packages deprecated (Legacy): "The Dotnet10 fork was a stopgap and is no longer supported. Use the official package instead." The only code that uses the library is
Context.cs(using EFCore.BulkExtensions;), and the namespace is unchanged.Verified
dotnet test --filter "Category!=Integration", with credential-looking environment variables removed: 103 passed, 0 failed.Not verified
The bulk-insert paths run against a real PostgreSQL or SQL Server database, and those tests are integration tests that CI and I cannot run. 10.0.0 to 10.0.1 of the official package is a patch release, but the first real run of an aggregation against a database is the check that matters, so this is worth a run on a non-production database before releasing.
Not included, left for the maintainers
These came from an automated clean-up attempt that I reviewed and did not take:
Serilog.Sinks.ElasticSearch(also deprecated) is referenced in the CLI project and the package pins but used nowhere in the source or the checked-in configuration. The attempt swapped it forElastic.Serilog.Sinks, a different library with a different API. Whether to remove the reference or replace it depends on deployment configuration I cannot see.LogicMonitor.Datamart.Cli/Dockerfile(useradd appuser,chown /app,USER appuser). Reasonable hardening, but it changes how the image runs, and the file still uses theaspnet:8.0andsdk:8.0bases while the project targets net10.AggregationWriterand six mapping profiles, and cosmetic edits to two applied EF migrations. Not worth the risk to code the tests do not exercise against a database.