Repository navigation
Release Notes check and cap apply from Ready for Test onwards - #10
Merged
davidnmbond merged 1 commit intoOct 29, 2026
Conversation
Before Ready for Test an empty Release Notes field scores 100 with 'Not required yet (status: ...)', as Fix Version does, and the Release notes mandatory cap no longer applies, so a ticket in Ready for Progress can reach EXCELLENT. Notes written early are still checked but do not cap. Reported in panoramicdata/PanoramicData.Skills#1910.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in panoramicdata/PanoramicData.Skills#1910.
Problem
The built-in ticket-quality rubric capped every MS ticket at 79 (GOOD) when Release Notes was empty, whatever its status. A ticket in Ready for Progress could never reach EXCELLENT, even though release notes cannot be written before the work is done. Fix Version was already status-aware; Release Notes was not. Observed on MS-27963.
Change
releaseNotesDue, a reference tocontractEvidenceDue(Ready for Test onwards), so the two MS status gates cannot drift apart.ReleaseNotesandEpicReleaseNotes: before Ready for Test an empty field scores 100 with○ Release Notes: Not required yet (status: ...).Release notesmandatory cap applies only from Ready for Test onwards. Notes already written earlier are still checked and their findings reported, but do not cap.The Skills
Send to testreadiness gate scores with-AsStatus 'Ready for Test', so it still refuses a ticket with no release notes.Tests
ReleaseNotesAssessmentTestsnow defaults to Ready for Test, and adds cases for empty notes before Ready for Test (Improvement and Epic), flawed notes before Ready for Test (reported, no cap), and empty notes at In Test and Closed (cap). All 999 tests pass; the four new cases fail against the previous rubric.After merge
Release the package, then bump the pin in PanoramicData.Skills
_common/IssueQuality.csand Magic Suite'sDirectory.Packages.props.