Skip to content

Release Notes check and cap apply from Ready for Test onwards - #10

Merged
davidnmbond merged 1 commit into
panoramicdata:mainfrom
ElizabethWhyman:fix/release-notes-from-ready-for-test
Oct 29, 2026
Merged

davidnmbond merged 1 commit into
panoramicdata:mainfrom
ElizabethWhyman:fix/release-notes-from-ready-for-test

Conversation

@ElizabethWhyman

Copy link
Copy Markdown
Contributor

Reported in panoramicdata/PanoramicData.Skills#1910.

Problem

The built-in ticket-quality rubric capped every MS ticket at 79 (GOOD) when Release Notes was empty, whatever its status. A ticket in Ready for Progress could never reach EXCELLENT, even though release notes cannot be written before the work is done. Fix Version was already status-aware; Release Notes was not. Observed on MS-27963.

Change

  • New named condition releaseNotesDue, a reference to contractEvidenceDue (Ready for Test onwards), so the two MS status gates cannot drift apart.
  • ReleaseNotes and EpicReleaseNotes: before Ready for Test an empty field scores 100 with ○ Release Notes: Not required yet (status: ...).
  • The Release notes mandatory cap applies only from Ready for Test onwards. Notes already written earlier are still checked and their findings reported, but do not cap.

The Skills Send to test readiness gate scores with -AsStatus 'Ready for Test', so it still refuses a ticket with no release notes.

Tests

ReleaseNotesAssessmentTests now defaults to Ready for Test, and adds cases for empty notes before Ready for Test (Improvement and Epic), flawed notes before Ready for Test (reported, no cap), and empty notes at In Test and Closed (cap). All 999 tests pass; the four new cases fail against the previous rubric.

After merge

Release the package, then bump the pin in PanoramicData.Skills _common/IssueQuality.cs and Magic Suite's Directory.Packages.props.

Before Ready for Test an empty Release Notes field scores 100 with 'Not required yet (status: ...)', as Fix Version does, and the Release notes mandatory cap no longer applies, so a ticket in Ready for Progress can reach EXCELLENT. Notes written early are still checked but do not cap. Reported in panoramicdata/PanoramicData.Skills#1910.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit eb8bb7b into panoramicdata:main Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants