Skip to content

Clear Codacy complexity and mapper duplication on main - #3

Merged
davidnmbond merged 1 commit into
mainfrom
fix/codacy-complexity-duplication
Oct 17, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
fix/codacy-complexity-duplication

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

The governance check on main was 91/93: CQ-05 (two methods over Codacy's complexity limit of 8) and CQ-06 (the Jira and GitHub mappers graded B for 9% duplication, and IssueText.cs for the same complexity issue).

  • CategoryExecutor.BuildCategoryResult and IssueText.Classify are split into smaller methods.
  • The two mappers' duplicated Text helper is now one internal JsonReading.StringAt.

No behaviour change; 833 tests pass.

🤖 Generated with Claude Code

Split CategoryExecutor.BuildCategoryResult and IssueText.Classify under the complexity limit, and move the Jira and GitHub mappers' duplicated JSON string reading into one helper.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -5 complexity · -2 duplication

Metric Results
Complexity -5
Duplication -2

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (485a75e) 2004 2003 99.95%
Head commit (9f2b577) 2004 (+0) 2003 (+0) 99.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3) 37 37 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit ea8461e into main Oct 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant