Skip to content

Split the three files Codacy grades B for file-level complexity - #4

Merged
davidnmbond merged 1 commit into
mainfrom
fix/file-level-complexity
Oct 17, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
fix/file-level-complexity

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

Governance on main is 92/93: CQ-06 (Info) because JiraIssueMapper.cs, IssueText.cs and RuleValidator.cs are graded B. They have no Codacy issues and no duplication; the grade comes from how much logic each file holds (JiraIssueMapper.cs had complexity 50 over 141 lines).

Split by responsibility, with no behaviour change:

  • JiraIssueMapper.cs loses its Atlassian Document Format flattening, now AdfFlattener.cs (internal; JiraIssueMapper.FlattenAdf still delegates to it).
  • IssueText becomes a partial class: public readers, Patterns, Panels and Sections files.
  • RuleValidator becomes a partial class: conditions, Measures, Syntax and Cycles files.

833 tests pass; coverage unchanged.

🤖 Generated with Claude Code

JiraIssueMapper loses its ADF flattening (new AdfFlattener); IssueText and RuleValidator become partial classes split by responsibility. No behaviour change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -1 complexity · 0 duplication

Metric Results
Complexity -1
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ea8461e) 2004 2003 99.95%
Head commit (d91a760) 2005 (+1) 2004 (+1) 99.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4) 199 199 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit 2882d0a into main Oct 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant