Repository navigation
Split the three files Codacy grades B for file-level complexity - #4
Merged
Merged
Conversation
JiraIssueMapper loses its ADF flattening (new AdfFlattener); IssueText and RuleValidator become partial classes split by responsibility. No behaviour change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -1 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (ea8461e) 2004 2003 99.95% Head commit (d91a760) 2005 (+1) 2004 (+1) 99.95% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#4) 199 199 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Governance on main is 92/93: CQ-06 (Info) because
JiraIssueMapper.cs,IssueText.csandRuleValidator.csare graded B. They have no Codacy issues and no duplication; the grade comes from how much logic each file holds (JiraIssueMapper.cshad complexity 50 over 141 lines).Split by responsibility, with no behaviour change:
JiraIssueMapper.csloses its Atlassian Document Format flattening, nowAdfFlattener.cs(internal;JiraIssueMapper.FlattenAdfstill delegates to it).IssueTextbecomes a partial class: public readers,Patterns,PanelsandSectionsfiles.RuleValidatorbecomes a partial class: conditions,Measures,SyntaxandCyclesfiles.833 tests pass; coverage unchanged.
🤖 Generated with Claude Code