Skip to content

remove x-p-log-source for otel ingestion, derive from endpoint - #1773

Open
nikhilsinhaparseable wants to merge 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:remove-log-source
Open

remove x-p-log-source for otel ingestion, derive from endpoint#1773
nikhilsinhaparseable wants to merge 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:remove-log-source

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes

    • Improved OTLP ingestion reliability by determining the log source from the selected endpoint rather than a request header.
    • Ensured the endpoint’s signal type takes precedence when assigning ingestion format details.
    • Removed obsolete log-source validation errors.
  • Documentation

    • Updated OTLP header documentation and generated ingestion configurations to reflect the streamlined header requirements.
  • Improvements

    • Simplified telemetry exports while preserving API key, stream, and optional tenant configuration.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3929e048-9d74-4404-90f9-b5abe630a481

📥 Commits

Reviewing files that changed from the base of the PR and between 4144a3e and bcd69c2.

📒 Files selected for processing (7)
  • scripts/ingest.ps1
  • scripts/ingest.sh
  • src/handlers/http/ingest.rs
  • src/handlers/http/modal/utils/ingest_utils.rs
  • src/otel_generator.rs
  • src/telemetry.rs
  • src/utils/header_parsing.rs
💤 Files with no reviewable changes (3)
  • scripts/ingest.sh
  • src/utils/header_parsing.rs
  • src/otel_generator.rs

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

OTLP ingestion now takes the log source from the endpoint. Exporters and ingestion scripts no longer send X-P-Log-Source. Signal streams use otel-demo-* names. Related validation errors and documentation were removed.

Changes

OTLP log source handling

Layer / File(s) Summary
Endpoint source resolution
src/handlers/http/ingest.rs, src/handlers/http/modal/utils/ingest_utils.rs
OTLP setup uses the endpoint LogSource. Custom field processing overrides FORMAT_KEY with that source. Related mismatch errors were removed. Tests cover conflicting request headers.
Export stream headers
src/otel_generator.rs, scripts/ingest.ps1
Signal streams use otel-demo-traces, otel-demo-metrics, and otel-demo-logs. Export requests send X-P-Stream without X-P-Log-Source.
Header contract cleanup
src/utils/header_parsing.rs, src/telemetry.rs
The missing log source parsing error and the obsolete OTLP header documentation example were removed.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to bcd69

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: parmesant

Poem

A rabbit watched the streams go by
No extra source header filled the sky
The endpoint chose the format bright
Demo streams hopped into flight
Clean headers made the burrow right

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required Description section and testing, comments, and documentation confirmations are missing. Add a pull request description that explains the goal, chosen solution and rationale, and key changes. Complete the applicable checklist items for ingestion and query testing, code comments, and documentation. Add or remove the issue refere…
Docstring Coverage ⚠️ Warning Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files. (1 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: OTEL ingestion no longer uses the x-p-log-source header and derives the log source from the endpoint.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add a pull request description that explains the goal, chosen solution and rationale, and key changes. Complete the applicable checklist items for ingestion and query testing, code comments, and documentation. Add or remove the issue reference as applicable.

Full details: Docstring Coverage

Explanation

Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant