remove x-p-log-source for otel ingestion, derive from endpoint - #1773
remove x-p-log-source for otel ingestion, derive from endpoint#1773nikhilsinhaparseable wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (3)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughOTLP ingestion now takes the log source from the endpoint. Exporters and ingestion scripts no longer send ChangesOTLP log source handling
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkResolution Add a pull request description that explains the goal, chosen solution and rationale, and key changes. Complete the applicable checklist items for ingestion and query testing, code comments, and documentation. Add or remove the issue reference as applicable. Full details: Docstring CoverageExplanation Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary by CodeRabbit
Bug Fixes
Documentation
Improvements