Repository navigation
[NO-TICKET] doctor: check that the live page names the build it runs - #455
Merged
Merged
Conversation
The build ID on the live page (window.__PATCHSTACK_BUILD__, written by setup and mark-build) is how Patchstack knows which build is published. Without it the dashboard has to guess, and its "Unpublished changes" compares against that guess. doctor --url now reports whether the page carries it, with the fix when it does not. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
🎯 Elite quality (99%) — Adds a focused doctor check for the live build marker, with matching docs and both-path tests. 📦 Small |
Contributor
Author
|
/review |
daniloradovic
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
doctor --urlnow also checks that the live page carries Patchstack's build ID (window.__PATCHSTACK_BUILD__, written into the page layout by setup and into built HTML bymark-build).That ID is how Patchstack knows which build is published. Without it the dashboard has to guess, and its "Unpublished changes" card compares against that guess. With the ID present, doctor reports ✓. Without it, doctor reports ✗ with the fix:
npx @patchstack/connect setup --widget, then publish.How it was verified
tests/doctor.test.ts(17 tests):__PATCHSTACK_BUILD__, and doctor reports ✓.Rollout
AGENT-INSTALL.mdchanges (one line in "Verifying the install"), so the hostile field test is owed after the release that carries this.🤖 Generated with Claude Code