fix(translations): correct mistranslated and untranslated strings in ja locale - #17830
Open
meikocho1 wants to merge 1 commit into
Open
fix(translations): correct mistranslated and untranslated strings in ja locale#17830meikocho1 wants to merge 1 commit into
meikocho1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Corrects 17 strings in the Japanese (
ja) locale — six that were never translated and eleven that were mistranslated. Translation strings only; no keys added or removed, so no other locale and no code is affected.Left in English
general.fieldFieldzh: '字段',de: 'Feld'general.noLabel<No {{label}}><{{label}}なし>ko: '<{{label}} 없음>',de: '<Kein {{label}}>'general.notFoundNot Foundzh: '未找到'general.nothingFoundNothing foundde: 'Keine Ergebnisse',ko: '찾을 수 없습니다'general.untitledUntitledzh: '无标题',de: 'Ohne Titel'hierarchy.noResultsNo results for "{{query}}"Mistranslated
authentication.resetPasswordExpirationpackages/payload/src/auth/baseFields/auth.ts).authentication.resetPasswordTokenfields.relatedDocumentko: '관련 문서',de: 'Verknüpftes Dokument').general.checkeduncheckedin the version diff view (ui/src/views/Version/RenderFieldsToDiff/fields/Checkbox), where the two did not read as a pair.general.uncheckedgeneral.editedSince{label} <strong>{date}</strong>inui/src/elements/DocumentLocked, producing "から編集 2026/08/18" — a dangling particle with nothing before it. Japanese needs the label to precede the date.general.updateForEveryoneui/src/elements/QueryPresets/QueryPresetBar), so it must be an action.general.whereui/src/elements/WhereBuilder/Condition, i.e. the query clause.general.documentIsTrashedtrash,emptyTrash,titleTrashed,noTrashResults).localization.localeToPublishlocale,locales,allLocales).localization.selectLocaleToDuplicateui/src/elements/DuplicateDocument/SelectLocalesDrawerto pick which locales to copy.Why?
These are the remaining correctness problems in the Japanese locale that are independent of style or tone. Each one either shows English in an otherwise translated admin panel, or states something different from the English source — most visibly
general.where, which labelled the query builder's clause row with the interrogative "どこ" (where is it?), andgeneral.checked/general.unchecked, which did not read as opposites in the version diff.How?
Edited the values in
packages/translations/src/languages/ja.ts. Every string was checked against its actual call site inpackages/uiand against the other locales, rather than translating the English label in isolation.Two known problems were deliberately left out of this PR:
general.by— rendered as`${t('general:by')} ${collection}`inui/src/elements/DefaultListViewTabs. Japanese needs this particle after the noun (投稿別), so it cannot be fixed by the string alone and would require a code change.general.true/general.false— still the literaltrue/falsewhere other locales localise them (ko: '참'/'거짓',zh: '是'/'否'). Comprehensible as-is, so this is a preference rather than a defect.