fix(plugin-nested-docs): guard against circular parent relationships - #17837
Open
r1tsuu wants to merge 1 commit into
Open
fix(plugin-nested-docs): guard against circular parent relationships#17837r1tsuu wants to merge 1 commit into
r1tsuu wants to merge 1 commit into
Conversation
`getParents` traversed the parent chain with no loop detection, so a document whose ancestor chain contained a cycle recursed until the request exhausted memory. The accumulator copies the breadcrumb array at every level, making the growth quadratic - a cyclic pair takes a Node process to a 4GB heap OOM in roughly 45 seconds, hanging the request and querying the database once per iteration the whole way. `parentFilterOptions` rejects cycles created through the API, so this is only reachable when a cycle gets into the database another way: a migration, a seed script, a direct adapter write, or a parent field that declares its own `filterOptions` and thereby replaces the plugin's guard. `getParents` now tracks the IDs it has already visited and stops the traversal when a parent repeats, logging a warning. It truncates rather than throwing so that affected documents stay editable and an editor can clear the parent field to repair the hierarchy. `resaveChildren` needed the same treatment: re-saving a child re-runs the hook for that child, so a cycle bounces updates between the documents forever once the breadcrumb traversal terminates. It now skips any document already being re-saved further up the current chain, scoped to the request so legitimate repeat re-saves are unaffected. Adds a `regions` test collection whose parent field overrides `filterOptions`, covering the configuration where a cycle can be created through the public API, alongside coverage for the database-level cycle and for the existing rejection of a descendant parent.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getParentstraversed the parent chain with no loop detection, so a document whose ancestor chain contained a cycle recursed until the request exhausted memory. The accumulator copies the breadcrumb array at every level, making the growth quadratic - a cyclic pair takes a Node process to a 4GB heap OOM in roughly 45 seconds, hanging the request and querying the database once per iteration the whole way.parentFilterOptionsrejects cycles created through the API, so this is only reachable when a cycle gets into the database another way: a migration, a seed script, a direct adapter write, or a parent field that declares its ownfilterOptionsand thereby replaces the plugin's guard.getParentsnow tracks the IDs it has already visited and stops the traversal when a parent repeats, logging a warning. It truncates rather than throwing so that affected documents stay editable and an editor can clear the parent field to repair the hierarchy.resaveChildrenneeded the same treatment: re-saving a child re-runs the hook for that child, so a cycle bounces updates between the documents forever once the breadcrumb traversal terminates. It now skips any document already being re-saved further up the current chain, scoped to the request so legitimate repeat re-saves are unaffected.Adds a
regionstest collection whose parent field overridesfilterOptions, covering the configuration where a cycle can be created through the public API, alongside coverage for the database-level cycle and for the existing rejection of a descendant parent.