Repository navigation
PRE-3677: PPRO display eligibility by amount and country - #337
Merged
hdelaforce-payplug merged 3 commits intoOct 27, 2026
Merged
Task list completed / task-list-completed
Started
2026-10-26 15:30:48
ago
7 / 11 tasks completed
4 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
Code is linted and formatted: ECS 0 errors, PHPStan level max 0 errors, no new baseline entry. PHPMD: no new violation (only violations that already exist on develop). |
Completed |
| No unnecessary commented-out code or debug logs | Completed |
No hardcoded values (use env variables or config): PayPlug limits come from the API and are stored in the gateway config. The PPRO method list, the 5-minute refresh interval and the 24-hour enabled TTL are class constants by design. |
Completed |
Unit tests added / updated: PHPUnit 1001 tests / 2231 assertions pass locally (PHP 8.3). node --test 11/11 for the admin validation logic, now also run in CI (npm test step in the coverage job). lint:container OK. |
Completed |
New/changed code is covered by tests — SonarCloud Quality Gate (coverage on new code) passes on the sonarcloud CI job: green on 6b81a97, with the full CI (PHPUnit matrix PHP 8.2/8.4 × Sylius 2.0/2.1, Coverage, PHP Quality) |
Completed |
| No sensitive data or secrets introduced | Completed |
Logging and error handling are appropriate: account-read and refresh failures are logged on the payplug channel and fail open. A failed refresh after OAuth or on the admin page shows a warning. The refresh command exits non-zero if a connected method could not be refreshed. |
Completed |
| Behat not run (no test DB available locally). | Incomplete |
| Admin Stimulus controller and UX Autocomplete country picker not yet checked in a browser. | Incomplete |
Refusal classification (details.amount / details.billing.country in the PayPlug error body) not checked against real sandbox responses: needs a Wero payment with a billing country outside BE/DE, and a Scalapay payment below its minimum, to add as test fixtures. |
Incomplete |
Merchant release notes: announce the payplug:ppro:refresh command and the admin asset rebuild. |
Incomplete |
Loading