Repository navigation
PHP 8.5: use a colon after case "PATCH" in WAC - #71
Open
chefboyrdave21 wants to merge 1 commit into
Open
chefboyrdave21 wants to merge 1 commit into
chefboyrdave21 wants to merge 1 commit into
Conversation
PHP 8.5 deprecates a case statement followed by a semicolon. With convertDeprecationsToExceptions enabled, every test that loads WAC fails on PHP 8.5, and production logs a deprecation for every request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5 deprecates a
casestatement followed by a semicolon (case "PATCH";inWAC::getRequestedGrants()). WithconvertDeprecationsToExceptionsenabled, any test that loadsWACfails on PHP 8.5, and in production every request logs a deprecation. Related: pdsinterop/solid-nextcloud#222.One character:
;becomes:.🤖 Generated with Claude Code