Skip to content

Return 201 Created from dynamic client registration - #230

Open
chefboyrdave21 wants to merge 1 commit into
pdsinterop:mainfrom
smilinTux:fix/register-201-created
Open

chefboyrdave21 wants to merge 1 commit into
pdsinterop:mainfrom
smilinTux:fix/register-201-created

Conversation

@chefboyrdave21

Copy link
Copy Markdown

Problem

RFC 7591 §3.2.1 requires a successful dynamic client registration to answer 201 Created. The endpoint answers 200 OK. Strict clients reject that: openid-client (used by @inrupt/solid-client-authn-node) fails with expected 201 Created, got: 200 OK, so a Node.js Solid app cannot log in at all.

Fix

Return Http::STATUS_CREATED from ServerController::register(). Browser clients accept both.

Tests

testRegisterWithRedirectUris now expects 201.

Verification

Verified on Nextcloud 35.0.2 (PHP 8.5) behind a reverse proxy that terminates TLS, with @inrupt/solid-client-authn-node 5.0.3 / @inrupt/solid-client 4.0.0 and in a headless browser. The unit suite passes in a Nextcloud 35 container.

🤖 Generated with Claude Code

RFC 7591 section 3.2.1 requires a successful client registration response
to use HTTP 201 Created. The endpoint returned 200 OK, which strict
clients reject. openid-client (used by @inrupt/solid-client-authn-node)
fails with "expected 201 Created, got: 200 OK", so Node.js Solid apps
could not log in against the pod at all.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant