Repository navigation
PER-18047: publish on Node 24 instead of upgrading npm on Node 20 - #138
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zeevmoney
approved these changes
Oct 30, 2026
zeevmoney
left a comment
Member
There was a problem hiding this comment.
Approved — no CRITICAL or HIGH issues found.
Non-blocking:
- LOW
.github/workflows/node_sdk_publish.yaml:22— publish job's actions are tag-pinned and checkout persists credentials - LOW
.github/workflows/node_sdk_publish.yaml:24— "Node 24 ships both" holds only for 24.5.0 and later
Release note (not a finding):
- A
releaserun uses the workflow file at the tagged commit, so re-running the failed2.7.7run will execute the old npm upgrade step again. The2.7.7release has to point at a commit that contains this change, or ship as a new version.
Details are in the inline comments on each line.
CarlosMion
approved these changes
Oct 30, 2026
…correct the Node comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow runs
npm install -g npm@lateston Node 20. npm 12 refuses Node 20 (EBADENGINE), so every release now fails at that step, before tests or publishing.npm's Trusted Publishing now also requires Node 22.14+, so pinning npm alone on Node 20 wouldn't be enough.
Changes
Testing
ci.yamlstill tests Node 18 and 20, and the release job runs the full test suite on Node 24 before it publishes.🤖 Generated with Claude Code