Repository navigation
fix(mobile): reject non-positive plot and animation pauses - #896
Open
huxiaoyi-ovo wants to merge 1 commit into
Open
huxiaoyi-ovo wants to merge 1 commit into
huxiaoyi-ovo wants to merge 1 commit into
Conversation
Validate scan pause durations and guard Vehicle's actual pyplot pause path while preserving pause=False's non-blocking refresh. Add focused headless and timeout-protected regression tests for both call sites. This changes invalid pause durations to a clear ValueError instead of allowing pyplot to wait indefinitely. Co-Authored-By: ChatGPT (GPT-6) <chatgpt@openai.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 146 146
Lines 17295 16690 -605
======================================
+ Misses 17295 16690 -605 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #876.
plt.pause(0)can block indefinitely. This covers bothPoseGraph.plot_scan()and Vehicle animation.pausevalues inPoseGraph.plot_scan().plt.pause(dt)call in Vehicle while preserving non-blockingpause=Falseand notebook-inline behaviour.Behaviour change: invalid blocking pause durations now raise
ValueError. Numerical results are unchanged.Validation: fork CI PR #11 (huxiaoyi-ovo#11), 20 jobs successful, one conditional skip; Python 3.10–3.14 across Linux, macOS and Windows, mypy, coverage and docs build.
AI assistance: ChatGPT (GPT-6) helped with code review and regression tests; I reviewed the patch and CI results.