Repository navigation
Conversation
Afloat16
marked this pull request as ready for review
November 3, 2026 13:56
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Particle resampling chooses the particle whose cumulative weight is nearest to a uniform draw. That does not sample the intended categorical distribution: for weights
[0.8, 0.2], the boundary is 0.9 rather than 0.8. Repeated CDF entries can also select zero-weight particles. This biases the next particle generation.Change
Use the inverse CDF intervals via
searchsorted(..., side="right"). Normalising by the last cumulative sum makes the final CDF entry exactly one. Remove the interpolation dependency that this code no longer needs.This corrects resampling probabilities and can change seeded particle-filter trajectories.
The regressions use a seeded generator, two independently specified probability thresholds, and intervening zero-weight particles. Expected particle indices are computed directly from those thresholds.
Validation
PYTHONPATH=src python -m pytest tests/test_particle_filter_api.py tests/test_particle_heading_moments.py -q: 41 passed, with 3 animation cleanup warnings.PYTHONPATH=src python -m pytest tests/test_vehicle_estimators.py -k TestParticleFilter -q: 7 passed, 40 deselected, checking the corrected resampling against the existing estimator tracking regressions.git diff --checkpassed.