Repository navigation
Conversation
Afloat16
marked this pull request as ready for review
November 3, 2026 13:56
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Vehicle simulation computes travelled distance with a norm, so reverse motion produces positive odometry. Feeding that odometry into the existing vehicle state transition predicts forward motion, breaking estimator prediction when a vehicle reverses.
Change
Project the translation increment onto the vehicle's heading before the state update to retain its sign. This uses the actual limited motion and handles differential steering even when one wheel moves forward while the vehicle reverses. The odometry docstring now explicitly describes signed distance.
The regression covers Bicycle, Unicycle and DiffSteer, with forward controls, reversing controls, nonzero heading and opposite wheel directions. It verifies that returned odometry reconstructs the actual next pose through
VehicleBase.f.Validation
PYTHONPATH=src python -m pytest tests/test_vehicle_estimators.py -q: 55 passed, 30 subtests passed.git diff --checkpassed.This corrects the sign of reverse odometry and consequently changes estimator trajectories for reversing vehicles.