Repository navigation
Conversation
Afloat16
marked this pull request as ready for review
November 3, 2026 13:57
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
Author
|
The follow-up in d282e72c preserves the default eight-connected queries and the existing book-path expectations. Four-connected behavior is now explicit through Current-head CI passes, including the compatibility tests, platform matrix, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The distance-transform metric and path connectivity are separate concerns. Restricting every Manhattan query to axial steps changes existing book-example paths. Callers need an explicit way to request four-connected paths while preserving the default behavior.
Change
connectivity=8, including the existing diagonal query steps and book-example paths for both distance metrics.connectivity=4to restrict both the distance transform and path extraction to horizontal and vertical moves. These moves have the same cost for either metric.connectivityproperty.Regression coverage
The tests cover axial steps and distance-map cost for
connectivity=4, unchanged default diagonal paths, unreachable diagonal gaps, and invalid connectivity values. The existing book-path compatibility expectations are unchanged.Validation
CI for current head
d282e72cpasses, including core tests, the Linux/macOS/Windows test matrix,mypy, coverage and the documentation build. The current head has 24 successful checks and 2 workflow-context skips.The previously reported three path-compatibility failures occurred on
09519319, before the opt-in change. The current description and validation refer tod282e72cd7e7af645030068718ca25a8f3ffb127.