Skip to content

clang-tidy: enable cppcoreguidelines-pro-bounds-array-to-pointer-decay - #3169

Open
xaemonn wants to merge 1 commit into
pgRouting:developfrom
xaemonn:tidy-array-to-pointer-decay
Open

xaemonn wants to merge 1 commit into
pgRouting:developfrom
xaemonn:tidy-array-to-pointer-decay

Conversation

@xaemonn

@xaemonn xaemonn commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Part of #3036

Changes in this PR:

  • Enable cppcoreguidelines-pro-bounds-array-to-pointer-decay by removing it from the list of disabled checks in .clang-tidy, as mentioned in my comment on Clang tidy checks that need fixes #3036.
  • No code changes are needed,the check reports no warnings on current develop.
  • Tested with clang-tidy 18.1.3 on develop (2572819), running only this check over src/ and the headers in include/
  • in Release and Debug builds: 0 warnings in both

CI on my fork:
https://github.com/xaemonn/pgrouting/actions?query=branch%3Atidy-array-to-pointer-decay

@pgRouting/admins

Summary by CodeRabbit

  • Chores
    • Updated static analysis configuration by removing one bounds-safety check from clang-tidy.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 527f38be-d039-4fe3-aa14-36d39afc14a8
📥 Commits

Reviewing files that changed from the base of the PR and between 2572819 and 434fd65.

📒 Files selected for processing: 1
  • .clang-tidy
💤 Files with no reviewable changes: 1
  • .clang-tidy

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The .clang-tidy configuration no longer includes the cppcoreguidelines-pro-bounds-array-to-pointer-decay check.

Changes

Clang-tidy configuration

Layer / File(s) Summary
Update configured checks
.clang-tidy
The configured clang-tidy checks no longer include cppcoreguidelines-pro-bounds-array-to-pointer-decay.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: cvvergara

Merge Risk: ⚪ Minimal · up to 434fd

The configuration enables the intended clang-tidy check and is ready to merge after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately states that the pull request enables the specified clang-tidy check by removing it from the disabled checks list.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the tidy list,
One rule has hopped away.
The rest remain in place,
While carrots crown the day.
Soft paws greet the change with cheer.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant