You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enable cppcoreguidelines-pro-bounds-array-to-pointer-decay by removing it from the list of disabled checks in .clang-tidy, as mentioned in my comment on Clang tidy checks that need fixes #3036.
No code changes are needed,the check reports no warnings on current develop.
Tested with clang-tidy 18.1.3 on develop (2572819), running only this check over src/ and the headers in include/
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 527f38be-d039-4fe3-aa14-36d39afc14a8
📥 Commits
Reviewing files that changed from the base of the PR and between 2572819 and 434fd65.
📒 Files selected for processing: 1
.clang-tidy
💤 Files with no reviewable changes: 1
.clang-tidy
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Walkthrough
The .clang-tidy configuration no longer includes the cppcoreguidelines-pro-bounds-array-to-pointer-decay check.
Changes
Clang-tidy configuration
Layer / File(s)
Summary
Update configured checks .clang-tidy
The configured clang-tidy checks no longer include cppcoreguidelines-pro-bounds-array-to-pointer-decay.
The configuration enables the intended clang-tidy check and is ready to merge after normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title accurately states that the pull request enables the specified clang-tidy check by removing it from the disabled checks list.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the tidy list, One rule has hopped away. The rest remain in place, While carrots crown the day. Soft paws greet the change with cheer.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3036
Changes in this PR:
.clang-tidy, as mentioned in my comment on Clang tidy checks that need fixes #3036.src/and the headers ininclude/CI on my fork:
https://github.com/xaemonn/pgrouting/actions?query=branch%3Atidy-array-to-pointer-decay
@pgRouting/admins
Summary by CodeRabbit