Repository navigation
fix(downloader): select protoc builds for macOS and Linux arm64 (osx, aarch_64) - #172
Merged
Merged
Conversation
…`, `aarch_64`) fix(downloader): prefer the host-arch macOS build over a universal one protoc names macOS `osx` and arm64 `aarch_64`, so no protoc asset matched on macOS and Linux arm64. A universal build ranked equal to the host-arch build, so the API order decided between them and macOS x64 got protoc's universal binary; it now ranks right after the host-arch build and still ahead of Rosetta. Closes #171 Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
osxis read as macOS andaarch_64/aarch-64as arm64, so protoc installs on macOS (Intel and Apple Silicon) and on Linux arm64.osx-universal_binarycounts as a universal macOS build, likedarwin-universal.Why?
rr get-grpc-tools(roadrunner-php/cli#76) could not install protoc on macOS and Linux arm64.Checklist
osx,aarch_64) #171