Repository navigation
feat: populate SERVER_ADDR - #2809
Merged
Merged
Conversation
Set $_SERVER['SERVER_ADDR'] to the IP address that accepted the connection, as Caddy's FastCGI transport, nginx and Apache do. Unix socket listeners have no IP address, so SERVER_ADDR stays unset there.
henderkes
approved these changes
Nov 4, 2026
henderkes
left a comment
henderkes
left a comment
Contributor
There was a problem hiding this comment.
Don't think it's actually part of the cgi spec, pho applications shouldn't rely on it, but I don't mind setting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
$_SERVER['SERVER_ADDR']to the IP address that accepted the connection, as Caddy's FastCGI transport, nginx and Apache do. Unix socket listeners have no IP address, soSERVER_ADDRstays unset there, and an operator-definedenv SERVER_ADDRstill overrides it.Port of caddyserver/caddy#7912 (caddyserver/caddy@546752e).
Claude Code (Claude Opus 5.5) wrote this port and its test.