Repository navigation
test: implement all session handler interfaces - #2811
Merged
Merged
Conversation
PHP 8.6 deprecates passing session_set_save_handler() an object without create_sid() and validateId(). The deprecation notices went into the response and broke TestPreviousRequestCodeDoesNotWriteToNextClient_worker. Implement SessionIdInterface and SessionUpdateTimestampHandlerInterface, like the other test session handlers.
henderkes
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red on PHP 8.6 since 10baf4b8: PHP 8.6 deprecates passingsession_set_save_handler()an object withoutcreate_sid()andvalidateId(). The notices end up in the response, soTestPreviousRequestCodeDoesNotWriteToNextClient_workerfails.TenantSessionHandlernow implementsSessionIdInterfaceandSessionUpdateTimestampHandlerInterface, like the other test session handlers.The same
mainrun also hitrealloc(): invalid pointeronce in the Caddy module tests on PHP 8.3 (TestShowTheCorrectThreadDebugStatus). I could not reproduce it in 15 runs on a Linux PHP 8.3 debug ZTS build, nor in 10 runs on macOS, and it does not appear in the previous 30 failed runs, so this PR does not touch it.Assistance Disclosure
Claude Code (Claude Opus 5.5) diagnosed the failure and wrote the fix. I reviewed and tested the result.