Repository navigation
chore: bump Go dependencies - #2814
Merged
Merged
Conversation
Caddy 2.11.9 makes the last entry of first_exist_fallback match even when the file doesn't exist. Until now the glob checked its existence on Unix, so a php_server without an index.php returned Caddy's 404 and let requests fall through. Use first_exist everywhere to keep that behavior, as Windows and the php-server command already do.
quic-go is held at v0.64.1: v0.65.0 removes an API Caddy 2.11.9 uses.
go 1.27.3 in caddy/go.mod (required by dependencies) would make setup-go pin that exact release again. Request the 1.27 line with check-latest instead, and drop the lint rule that forbade patch releases in go.mod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the root and
caddymodules, including Caddy 2.11.9, Mercure 1.1.6, Vulcain 1.4.6 and golang.org/x/net 0.62.0.h3qlog.DefaultConnectionTracer, which Caddy 2.11.9 still uses.first_exist_fallbackmatch even when the file doesn't exist.php_serverrelied on the existence check on Unix, so without anindex.phpit now reached PHP ("No input file specified.") instead of returning Caddy's 404 and falling through. It now usesfirst_exist, like Windows and thephp-servercommand already did.caddy/go.modnow requires Go 1.27.3, because mercure/caddy, vulcain/caddy and slackhq/nebula do.go getadds that patch release back, so the lint rule from ci: build with the latest Go patch release #2776 can't hold. Thesetup-goaction now requests1.27withcheck-latestinstead of readinggo.mod, so every workflow builds with the latest 1.27 patch release whatevergo.modrequires, as in chore: bump dependencies dunglas/mercure#1470.