Skip to content

fix: build with non-ZTS PHP #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Nov 6, 2026
Merged

fix: build with non-ZTS PHP #2819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frankenphp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,6 +1404,7 @@ static int frankenphp_startup(sapi_module_struct *sapi_module) {

static int frankenphp_deactivate(void) { return SUCCESS; }

#ifdef ZTS
/* ext/date's post-deactivate hook frees last_errors, which its GINIT leaves
* uninitialized, even when a failed startup skipped its RINIT
* TODO: remove when only PHP versions with the fix are supported (8.4.28+,
Expand All @@ -1414,6 +1415,7 @@ static void frankenphp_init_date_globals(void) {
zend_date_globals *globals = ts_resource(*date->globals_id_ptr);
globals->last_errors = NULL;
}
#endif

static void frankenphp_handle_aborted_connection(void) {
/* a bailout would fail php_request_startup(), let the script's first write
Expand Down
Loading