Repository navigation
Conversation
Member
|
Please rebase after #75 |
mailparse_msg_free() passed any resource to zend_list_close(), so mailparse_msg_free($stream) closed the stream. Fetch the resource as a mailparse message first, as the other mailparse_msg_*() functions do. An already closed resource still returns true.
iliaal
force-pushed
the
fix-msg-free-foreign-resource
branch
from
November 6, 2026 13:20
750ab7d to
e42b4fb
Compare
Member
Author
|
Rebased |
Member
|
Ammended (package.xml) and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mailparse_msg_free()handed any resource tozend_list_close(), somailparse_msg_free($stream)closed the stream. It now fetches the resource as a mailparse message like the othermailparse_msg_*()functions, so a foreign resource raises a TypeError (a warning on PHP 7), and it still returns true for a handle that was already freed. Depends on #75; only the last commit is new here.