ext/dom: DOMDocument::adoptNode() stale document references in the ad… - #23358
Open
devnexen wants to merge 1 commit into
Open
ext/dom: DOMDocument::adoptNode() stale document references in the ad…#23358devnexen wants to merge 1 commit into
devnexen wants to merge 1 commit into
Conversation
…opted subtree. Fix php#23352 php_dom_transfer_document_ref() only retargeted the leftmost descendant chain, and never an attribute's value nodes, leaving retained nodes pointing at the freed source document. Replaced with an iterative walk over the whole subtree.
This was
linked to
issues
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…opted subtree.
Fix #23352
php_dom_transfer_document_ref() only retargeted the leftmost descendant chain, and never an attribute's value nodes, leaving retained nodes pointing at the freed source document. Replaced with an iterative walk over the whole subtree.