Skip to content

ext/dom: DOMNode::insertBefore() dropping the node used as its own re… #23379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devnexen wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
Draft

ext/dom: DOMNode::insertBefore() dropping the node used as its own re… #23379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/dom/node.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,9 @@ static void dom_node_insert_before_legacy(zval *return_value, zval *ref, dom_obj
php_dom_throw_error(NOT_FOUND_ERR, stricterror);
RETURN_FALSE;
}
if (refp == child) {
refp = child->next;
}
}

if (child->doc == NULL && parentp->doc != NULL) {
Expand All @@ -940,7 +943,7 @@ static void dom_node_insert_before_legacy(zval *return_value, zval *ref, dom_obj

php_libxml_invalidate_node_list_cache(intern->document);

if (ref != NULL) {
if (refp != NULL) {
if (child->parent != NULL) {
xmlUnlinkNode(child);
}
Expand Down
53 changes: 53 additions & 0 deletions ext/dom/tests/gh23365.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
--TEST--
GH-23365 (DOMNode::insertBefore($n, $n) drops the node and leaves a self-referencing sibling list)
--CREDITS--
Alexandre Daubois
--EXTENSIONS--
dom
--FILE--
<?php
$doc = new DOMDocument();
$doc->loadXML('<root>text<child/></root>');
$root = $doc->documentElement;

$text = $root->firstChild;
var_dump($root->insertBefore($text, $text) === $text);
var_dump($root->childNodes->length);
var_dump($text->parentNode === $root, $text->nextSibling === $text, $text->previousSibling === $text);

$child = $root->lastChild;
var_dump($root->insertBefore($child, $child) === $child);
var_dump($root->childNodes->length);

echo $doc->saveXML($root), PHP_EOL;

$doc2 = new DOMDocument();
$doc2->loadXML('<root a="1" b="2"/>');
$el = $doc2->documentElement;
$attr = $el->getAttributeNode('a');
var_dump($el->insertBefore($attr, $attr) === $attr);
echo $doc2->saveXML($el), PHP_EOL;

$doc3 = new DOMDocument();
$root3 = $doc3->appendChild($doc3->createElement('root'));
$root3->appendChild($doc3->createTextNode('A'));
$t = $root3->appendChild($doc3->createTextNode('B'));
$root3->insertBefore($t, $t);
$root3->appendChild($t);
echo $doc3->saveXML($root3), PHP_EOL;
unset($t, $root3, $doc3);
echo "done", PHP_EOL;
?>
--EXPECT--
bool(true)
int(2)
bool(true)
bool(false)
bool(false)
bool(true)
int(2)
<root>text<child/></root>
bool(true)
<root a="1" b="2"/>
<root>AB</root>
done
Loading