ext/gd: Add ZPP specifiers for array|float parameters - #23384
Open
LamentXU123 wants to merge 3 commits into
Open
ext/gd: Add ZPP specifiers for array|float parameters#23384LamentXU123 wants to merge 3 commits into
LamentXU123 wants to merge 3 commits into
Conversation
Member
|
I was thinking a custom one for the GD extension defined in the GD extension. As I don't think any other extension is going to utilize this. |
LamentXU123
marked this pull request as draft
August 19, 2026 15:34
LamentXU123
changed the title
LamentXU123
marked this pull request as ready for review
August 19, 2026 15:43
Member
Author
|
Either way make sense to me. Also I am aware the old test file doesn't test exception types. Don't need to change them in this PR if we want to change them we can do it in bulk. |
Girgias
approved these changes
Aug 19, 2026
|
|
||
| if ((tmp = zend_hash_str_find(Z_ARRVAL_P(options), "x", sizeof("x") - 1)) != NULL) { | ||
| if ((tmp = zend_hash_str_find(options, "x", sizeof("x") - 1)) != NULL) { | ||
| x = zval_get_double(tmp); |
Member
There was a problem hiding this comment.
Future PR: Ideally this should use a stricter variant as tmp could be an object of an array and still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #23356 (comment)_ cc @Girgias