-
Notifications
You must be signed in to change notification settings - Fork 8.1k
ext/standard: Make str_ends_with frameless
#23510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2451,7 +2451,10 @@ function str_contains(string $haystack, string $needle): bool {} | |
| */ | ||
| function str_starts_with(string $haystack, string $needle): bool {} | ||
|
|
||
| /** @compile-time-eval */ | ||
| /** | ||
| * @compile-time-eval | ||
| * @frameless-function {"arity": 2} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why not all "compile-time-eval" functions are not frameless?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah Perhaps a good idea for me to look into later. At least some of them should be frameless. e.g. ltrim rtrim.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think every compile time evaluable function should necessarily also have a frameless function. |
||
| */ | ||
| function str_ends_with(string $haystack, string $needle): bool {} | ||
|
|
||
| /** | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be reserved for large algorithmic improvement, not for any minor thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I will revert it as soon as I get back to my computer.