Skip to content

ext/spl: Share arrays copy-on-write in ArrayObject and ArrayIterator #23945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-grekas wants to merge 3 commits into
base: master
Choose a base branch
from
+1,815 −27
Open

ext/spl: Share arrays copy-on-write in ArrayObject and ArrayIterator #23945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47c7da9
Fix GH-17935: Separate ArrayObject and ArrayIterator storage on write
nicolas-grekas Nov 12, 2026
7d3e226
ext/spl: Share arrays copy-on-write in ArrayObject and ArrayIterator
nicolas-grekas Nov 12, 2026
d01b76f
ext/spl: Share immutable arrays in ArrayObject and ArrayIterator
nicolas-grekas Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ PHP NEWS
(Ilia Alshanetsky)

- SPL:
. ArrayObject and ArrayIterator now share the arrays they are given or hand
out until one side modifies them. (Nicolas Grekas)
. Fixed bug GH-17935 (Assertion failure Zend/zend_hash.c when appending to
serialized ArrayObject). (Nicolas Grekas)
. Fixed bug GH-23385 (SplDoublyLinkedList::serialize() use-after-free when
__serialize() removes an element). (David Carlier)

Expand Down
5 changes: 5 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ PHP 8.7 UPGRADE NOTES
target does not keep is now released at that assignment instead of after
the last one.

- SPL:
. ArrayObject and ArrayIterator no longer copy the arrays they are given or
hand out (constructor, exchangeArray(), getArrayCopy(), clone, array cast)
until one side modifies them, unless these arrays hold references.

- Standard:
. Improved performance of strcspn() and strpbrk() when searching longer strings
with a single-byte character mask.
Expand Down
Loading
Loading