Repository navigation
ext/fileinfo: Fix HWPX misidentification as OOXML - #25105
Merged
Merged
Conversation
Member
|
CI failure is legitimate |
ndossche
approved these changes
Nov 1, 2026
Member
Author
|
@php/release-managers-86 Ping :), we now may need to chrry-pick this to 8.6.0, also #25063 |
mbeccati
approved these changes
Nov 10, 2026
LamentXU123
added a commit
that referenced
this pull request
Nov 10, 2026
* PHP-8.6: ext/fileinfo: Fix HWPX misidentification as OOXML (#25105)
mbeccati
pushed a commit
that referenced
this pull request
Nov 10, 2026
Follow-up #25051. I find another regression in this upgrade. The OOXML magic rule can match .png or .md filenames later in an HWPX archive which means finfo can identify it as application/octet-stream instead of application/x-hwp+zip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #25051. I find another regression in this upgrade. The OOXML magic rule can match .png or .md filenames later in an HWPX archive which means finfo can identify it as application/octet-stream instead of application/x-hwp+zip.
Hopefully this is the last one. Beside this, I didn't find any other regressions.
I will add a NEWS entry when merging, to avoid conflicts.