Skip to content

Update IR (exclude ir_ra_simple) - #25180

Merged
jorgsowa merged 2 commits into
php:masterfrom
jorgsowa:update-ir-43d1d10
Nov 5, 2026
Merged

jorgsowa merged 2 commits into
php:masterfrom
jorgsowa:update-ir-43d1d10

Conversation

@jorgsowa

@jorgsowa jorgsowa commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

IR commit: 4a1208ccbfc8ca32a5103baf9820ad3cbb6ff06e

@iliaal iliaal left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs dstogov/ir#297 to merge

@jorgsowa

jorgsowa commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I will update the PR when it lands in IR.

@ndossche ndossche mentioned this pull request Nov 4, 2026
@iluuu1994 iluuu1994 mentioned this pull request Nov 5, 2026
@iluuu1994

Copy link
Copy Markdown
Member

Do we need ir_ra_fast.c at all? I just removed it in GH-25198 (didn't see this PR). It does rely on ir_jit_compile() not being used so that linking succeeds, which is slightly hacky. Or are there plans to use the new register allocator?

@dstogov

dstogov commented Nov 5, 2026

Copy link
Copy Markdown
Member

You don't need to merge ir_ra_simple.c and ir_ra_fast.c. They are not used.

@jorgsowa jorgsowa changed the title Update IR Update IR (exclude ir_ra_simple) Nov 5, 2026
IR commit: 43d1d1023a6ea811b11b39ed738f5e18696a1254
IR commit: 4a1208ccbfc8ca32a5103baf9820ad3cbb6ff06e

Stop bundling ir_ra_simple.c and ir_ra_fast.c, which are not used.
@jorgsowa

jorgsowa commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

I removed both ir_ra_simple and ir_ra_fast allocators from PR. It doesn't make sense to include them if they are unused.

@jorgsowa
jorgsowa merged commit 454c7a6 into php:master Nov 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants