Skip to content

Copy the context name in SNMP::setSecurity() #25205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lacatoire wants to merge 1 commit into from
Closed

Copy the context name in SNMP::setSecurity() #25205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/snmp/snmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ static void netsnmp_session_free(php_snmp_session **session) /* {{{ */
PHP_SNMP_SESSION_FREE(community);
PHP_SNMP_SESSION_FREE(securityName);
PHP_SNMP_SESSION_FREE(contextEngineID);
PHP_SNMP_SESSION_FREE(contextName);
efree(*session);
*session = NULL;
}
Expand Down Expand Up @@ -1169,7 +1170,10 @@ static ZEND_ATTRIBUTE_NONNULL_ARGS(2) bool netsnmp_session_set_security(struct s

/* Setting contextName if specified */
if (contextName) {
session->contextName = ZSTR_VAL(contextName);
if (session->contextName) {
efree(session->contextName);
}
session->contextName = estrndup(ZSTR_VAL(contextName), ZSTR_LEN(contextName));
session->contextNameLen = ZSTR_LEN(contextName);
}

Expand Down
22 changes: 22 additions & 0 deletions ext/snmp/tests/snmp-object-setSecurity-contextName.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
--TEST--
SNMP::setSecurity() - the context name is copied
--EXTENSIONS--
snmp
--SKIPIF--
<?php
require_once(__DIR__.'/skipif.inc');
?>
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');

$session = new SNMP(SNMP::VERSION_3, $hostname, $rwuser, $timeout, $retries);
$context = str_repeat('c', 5) . random_int(10, 99);
$session->setSecurity('authPriv', 'MD5', $auth_pass, 'AES', $priv_pass, $context);
unset($context);
// The agent does not know this context, only the lifetime of the name matters.
var_dump(@$session->get('.1.3.6.1.2.1.1.1.0'));
$session->close();
?>
--EXPECT--
bool(false)
Loading