Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, php_stdiop_read() polls a non-blocking pipe with PeekNamedPipe() and usleep(10) for a bounded number of rounds. When that wait runs out on a pipe that is still open, count drops to 0, read() returns 0 and the stream gets marked as EOF. Since usleep(10) is ~15ms on Windows, this hits a silent STDIN after about 13.5 hours and the CLI process just ends.
Now a wait that runs out while PeekNamedPipe() still succeeds returns 0 without setting eof, so the read still comes back empty but feof() stays false. A broken pipe still makes PeekNamedPipe() fail and ends in EOF as before. This is the change suggested in the issue. No test, since it would need to wait out the full loop.
Fixes #25204