Skip to content

ext/openssl: Fix shared SSL_CTX callbacks reading a freed session stream #25211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iliaal wants to merge 1 commit into from
Closed

ext/openssl: Fix shared SSL_CTX callbacks reading a freed session stream #25211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ PHP NEWS
- OpenSSL:
. Fixed bug GH-25172 (TLS session reuse shares request-lifetime callback
structures with persistent streams). (cxxz16, David Carlier)
. Fixed use-after-free in TLS server ALPN and Windows certificate checks
when the session stream passed to stream_socket_enable_crypto() is closed
before the handshake. (Ilia Alshanetsky)

05 Nov 2026, PHP 8.6.0RC5

Expand Down
59 changes: 59 additions & 0 deletions ext/openssl/tests/session_resumption_server_alpn_closed_parent.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
--TEST--
Server ALPN selection on a stream seeded from a closed session stream
--EXTENSIONS--
openssl
--FILE--
<?php
$certFile = __DIR__ . DIRECTORY_SEPARATOR . 'session_resumption_server_alpn_closed_parent.pem.tmp';
include 'CertificateGenerator.inc';
(new CertificateGenerator())->saveNewCertAsFileWithKey('localhost', $certFile);

$server = stream_socket_server('tcp://127.0.0.1:0');
$addr = stream_socket_get_name($server, false);

$parentClient = stream_socket_client("tcp://$addr");
$parent = stream_socket_accept($server);
stream_context_set_options($parent, ['ssl' => [
'local_cert' => $certFile,
'alpn_protocols' => 'h2,http/1.1',
]]);
stream_set_blocking($parent, false);
var_dump(stream_socket_enable_crypto($parent, true, STREAM_CRYPTO_METHOD_TLS_SERVER));

$client = stream_socket_client("tcp://$addr", $errno, $errstr, 5, STREAM_CLIENT_CONNECT,
stream_context_create(['ssl' => [
'verify_peer' => false,
'verify_peer_name' => false,
'alpn_protocols' => 'h2',
]]));
$child = stream_socket_accept($server);
stream_set_blocking($child, false);
var_dump(stream_socket_enable_crypto($child, true, STREAM_CRYPTO_METHOD_TLS_SERVER, $parent));

fclose($parent);
fclose($parentClient);

stream_set_blocking($client, false);
$clientDone = $childDone = 0;
for ($i = 0; $i < 1000 && ($clientDone !== true || $childDone !== true); $i++) {
if ($clientDone !== true) {
$clientDone = stream_socket_enable_crypto($client, true, STREAM_CRYPTO_METHOD_TLS_CLIENT);
}
if ($childDone !== true) {
$childDone = stream_socket_enable_crypto($child, true, STREAM_CRYPTO_METHOD_TLS_SERVER);
}
usleep(1000);
}
var_dump($clientDone, $childDone);
var_dump(stream_get_meta_data($client)['crypto']['alpn_protocol']);
?>
--CLEAN--
<?php
@unlink(__DIR__ . DIRECTORY_SEPARATOR . 'session_resumption_server_alpn_closed_parent.pem.tmp');
?>
--EXPECT--
int(0)
int(0)
bool(true)
bool(true)
string(2) "h2"
22 changes: 18 additions & 4 deletions ext/openssl/xp_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,8 @@ static int php_openssl_win_cert_verify_callback(X509_STORE_CTX *x509_store_ctx,
bool is_self_signed = false;


stream = (php_stream*)arg;
SSL *ssl = X509_STORE_CTX_get_ex_data(x509_store_ctx, SSL_get_ex_data_X509_STORE_CTX_idx());
stream = (php_stream*)SSL_get_ex_data(ssl, php_openssl_get_ssl_stream_data_index());
sslsock = (php_openssl_netstream_data_t*)stream->abstract;

{ /* First convert the x509 struct back to a DER encoded buffer and let Windows decode it into a form it can work with */
Expand Down Expand Up @@ -1020,7 +1021,7 @@ static zend_result php_openssl_enable_peer_verification(SSL_CTX *ctx, php_stream
}
} else {
#ifdef PHP_WIN32
SSL_CTX_set_cert_verify_callback(ctx, php_openssl_win_cert_verify_callback, (void *)stream);
SSL_CTX_set_cert_verify_callback(ctx, php_openssl_win_cert_verify_callback, NULL);
#else
if (sslsock->is_client && !SSL_CTX_set_default_verify_paths(ctx)) {
php_stream_warn(stream, ProtocolError,
Expand Down Expand Up @@ -1649,7 +1650,10 @@ static int php_openssl_server_alpn_callback(SSL *ssl_handle,
const unsigned char **out, unsigned char *outlen,
const unsigned char *in, unsigned int inlen, void *arg) /* {{{ */
{
php_openssl_netstream_data_t *sslsock = arg;
php_stream *stream = (php_stream *)SSL_get_ex_data(ssl_handle, php_openssl_get_ssl_stream_data_index());
php_openssl_netstream_data_t *sslsock = (php_openssl_netstream_data_t *)stream->abstract;

ZEND_ASSERT(sslsock->alpn_ctx.data != NULL);

if (SSL_select_next_proto((unsigned char **)out, outlen, sslsock->alpn_ctx.data, sslsock->alpn_ctx.len, in, inlen) != OPENSSL_NPN_NEGOTIATED) {
return SSL_TLSEXT_ERR_NOACK;
Expand Down Expand Up @@ -2707,7 +2711,7 @@ static zend_result php_openssl_create_server_ctx(php_stream *stream,
} else {
sslsock->alpn_ctx.data = (unsigned char *) pestrndup((const char*)alpn, alpn_len, php_stream_is_persistent(stream));
sslsock->alpn_ctx.len = alpn_len;
SSL_CTX_set_alpn_select_cb(sslsock->ctx, php_openssl_server_alpn_callback, sslsock);
SSL_CTX_set_alpn_select_cb(sslsock->ctx, php_openssl_server_alpn_callback, NULL);
}

efree(alpn);
Expand Down Expand Up @@ -2808,6 +2812,16 @@ static zend_result php_openssl_setup_crypto(php_stream *stream,
} else {
SSL_CTX_up_ref(parent_sslsock->ctx);
sslsock->ctx = parent_sslsock->ctx;
#ifdef HAVE_TLS_ALPN
if (parent_sslsock->alpn_ctx.data) {
if (sslsock->alpn_ctx.data) {
pefree(sslsock->alpn_ctx.data, php_stream_is_persistent(stream));
}
sslsock->alpn_ctx.data = (unsigned char *) pestrndup((const char *) parent_sslsock->alpn_ctx.data,
parent_sslsock->alpn_ctx.len, php_stream_is_persistent(stream));
sslsock->alpn_ctx.len = parent_sslsock->alpn_ctx.len;
}
#endif
if (parent_sslsock->session_callbacks) {
parent_sslsock->session_callbacks->refcount++;
sslsock->session_callbacks = parent_sslsock->session_callbacks;
Expand Down
Loading