Repository navigation
Conversation
querySelectorAll() returned an element once per matching selector of a selector list. This was fixed by phpGH-24260, whose test only covers class and :is() selectors; cover selector lists using combinators too. Closes phpGH-25210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-25210 reported that
querySelectorAll()returns an element once per matching selector of a selector list, e.g.ul li, ol li. That was already fixed by GH-24260 (d1fdbba), but the test for that fix only covers class and:is()selector lists.This adds a test for selector lists that use descendant and child combinators, run both from the document and from an element. It fails on 8.5.12 and passes on PHP-8.4 at the current HEAD.
Test-only change; no NEWS entry.