Repository navigation
Remove ENT_SUBSTITUTE from decode functions - #25223
Open
kamil-tekiela wants to merge 1 commit into
Open
kamil-tekiela wants to merge 1 commit into
kamil-tekiela wants to merge 1 commit into
Conversation
kocsismate
approved these changes
Nov 9, 2026
| { | ||
| zend_string *str; | ||
| zend_long quote_style = ENT_QUOTES|ENT_SUBSTITUTE; | ||
| zend_long quote_style = ENT_QUOTES; |
Member
There was a problem hiding this comment.
question: Would it make sense to add ENT_HTML401 here as well? I know it won't make much difference in practice, but maybe it's better for understandability? (at least I had to check why it was possible to omit it from the C code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-9582
It looks like it was added by accident to decode functions when the default was changed to convert both single and double quotes.