Repository navigation
ext/sodium: Accept an optional tweak for ipcrypt ND and NDX - #25246
Open
rafamolina1 wants to merge 1 commit into
Open
rafamolina1 wants to merge 1 commit into
rafamolina1 wants to merge 1 commit into
Conversation
Callers can reproduce a ciphertext from the ipcrypt draft vectors. Omitting the tweak still generates a random one.
Author
|
Hello, team, waiting for a review on this, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sodium_crypto_ipcrypt_nd_encrypt()andsodium_crypto_ipcrypt_ndx_encrypt()take an optional$tweak. Omitting it still generates a random tweak, so existing calls keep working.The ipcrypt functions themselves already landed in PHP 8.6 (GH-20960). This follows up on GH-25242 by making the non-deterministic modes reproducible.
Test plan
make test TESTS="ext/sodium/tests/crypto_ipcrypt.phpt ext/sodium/tests/crypto_ipcrypt_nd.phpt ext/sodium/tests/crypto_ipcrypt_pfx.phpt ext/sodium/tests/sodium_bin2ip.phpt"against libsodium 1.0.21